Node permissions fail to import [#1187858]

Comment	File	Size	Author
#27	1187858.27-features.patch	1.34 KB	mrfelton

#21	features-1187858.patch	1.37 KB	smk-ka

#17	features-1187858-17.patch	1.86 KB	febbraro

#11	features_debug.tar_.gz	2.9 KB	recidive
#1	features-user-permissions-1187858.patch	750 bytes	smk-ka

File	Size
features-user-permissions-1187858.patch	750 bytes

Comment #2

febbraro CreditAttribution: febbraro commented 15 September 2011 at 01:30

Assigned:

Unassigned

» febbraro

Log in or register to post comments

Comment #3

recidive CreditAttribution: recidive commented 15 September 2011 at 03:57

#1265168: Rebuild the file list properly when a feature is enabled or disabled has more information than this one. This problem affects all entities, not just nodes, and it's related to a module adding a permission that has to do with an entity instantiated in other module.

Log in or register to post comments

Comment #4

recidive CreditAttribution: recidive commented 19 September 2011 at 15:46

Priority:

Normal

» Major

Hey guys, can we do a sprint to get this fixed. I'm stuck on this issue for 3 weeks now. Need to get this sorted out in order to move my install profile forward.

Log in or register to post comments

Comment #5

febbraro CreditAttribution: febbraro commented 20 September 2011 at 02:10

Does the patch in #1 fix it for you?

Log in or register to post comments

Comment #6

febbraro CreditAttribution: febbraro commented 20 September 2011 at 02:12

Also, the best way to get this fixed in your time frame is to debug it and fix it and post a patch which we can review and commit. Also, with your patch, if you can provide more detail so that folks can have a specific test case and a patch to verify.

Log in or register to post comments

Comment #7

recidive CreditAttribution: recidive commented 20 September 2011 at 02:25

@febbraro, no patch in #1 doesn't fix the problem.

I'm debugging this for 3 weeks now, have tried changing things in a myriad of ways. I'm looking forward to have a patch to send. But can't find where the problem is. I'm sure it's related to installing using drush si/aegir, since the problem doesn't occur when using the installer (install.php).

I'm looking for some guidance from Features experts so I can look for the problem in the correct place.

I'm pretty sure this issue is the same as in #1063204: Adding a new permission causes integrity constraint violation. I'll try latest dev code now that #1195432: Use dependency information when importing got committed.

Log in or register to post comments

Comment #8

recidive CreditAttribution: recidive commented 20 September 2011 at 02:38

#1195432: Use dependency information when importing doesn't fix the problem. Can we mark this issue duplicate of #1063204: Adding a new permission causes integrity constraint violation?

Log in or register to post comments

Comment #9

smk-ka CreditAttribution: smk-ka commented 21 September 2011 at 09:28

Assigned:	Unassigned	» febbraro
Status:	Fixed	» Needs review

#1195432: Use dependency information when importing shouldn't be related, as it only helps with dependencies on module level (i.e., those in .info files). What you are describing sounds more like a dependency issue related to feature *components*, i.e. to my knowledge there isn't a way to tell features to first import the taxonomy vocabularies, which are required later down the pipeline when importing user permissions. You could try adding echo 1; at the top of taxonomy_features_rebuild() function, and echo 2; at the top of user_permission_features_rebuild() to see in which order they're actually executed. This would help to find out whether it's an execution order issue, or a caching issue.

And yes, we need to be able to reproduce this issue. From the various issues at hand (esp. #1265168-1: Rebuild the file list properly when a feature is enabled or disabled) it seems like we have to

create a vocabulary
setup some permissions
export both to a feature
add the feature as a dependency to Drupal's "minimal" install profile
install using drush si features_debug --uri=http://default --db-url=mysql://user:pass@localhost/dbname

Log in or register to post comments

Comment #10

recidive CreditAttribution: recidive commented 20 September 2011 at 12:42

@smk-ka: thanks! Yes, I'm going to create an install profile to help reproduce the problem.

Log in or register to post comments

Comment #11

recidive CreditAttribution: recidive commented 20 September 2011 at 16:09

File	Size
features_debug.tar_.gz	2.9 KB

Ok, I've created an install profile, starting from a copy of minimal, to help reproduce the problem.

I added a feature module that creates an user role a taxonomy vocabulary and set permissions for administrating, adding and deleting terms to the vocabulary.

Here are the errors that occur when installing a new site using this profile:

Starting Drupal installation. This takes a few seconds ...                                          [ok]
Missing argument 1 for features_enable() features.module:817                                        [warning]
array_keys() expects parameter 1 to be array, null given features.module:819                        [warning]
Invalid argument supplied for foreach() features.module:775                                         [warning]
WD php: PDOException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'module' cannot  [error]
be null: INSERT INTO {role_permission} (rid, permission, module) VALUES (:db_insert_placeholder_0,
:db_insert_placeholder_1, :db_insert_placeholder_2); Array
(
    [:db_insert_placeholder_0] => 3
    [:db_insert_placeholder_1] => delete terms in 1
    [:db_insert_placeholder_2] => 
)
 in user_role_grant_permissions() (line 3028 of
/Users/henrique/Webroot/drupal7/modules/user/user.module).
Cannot modify header information - headers already sent by (output started at                       [warning]
/Users/henrique/drush/includes/drush.inc:917) bootstrap.inc:1207
PDOException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column &#039;module&#039; cannot be null: INSERT INTO {role_permission} (rid, permission, module) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2); Array
(
    [:db_insert_placeholder_0] => 3
    [:db_insert_placeholder_1] => delete terms in 1
    [:db_insert_placeholder_2] => 
)
 in user_role_grant_permissions() (line 3028 of /Users/henrique/Webroot/drupal7/modules/user/user.module).
Drush command terminated abnormally due to an unrecoverable error.                                  [error]

Note: the Missing argument 1 for features_enable() error was introduced in latest commits made in Features module, this was not happening few weeks ago.

To reproduce the issue:

Extract the install profile to the /profiles folder of a Drupal 7 core codebase
Add latest Features module to sites/all/modules or profiles/features_debug/modules
Install the site using drush si features_debug --db-url=mysql://root:pass@localhost:port/dbname

Log in or register to post comments

Comment #12

recidive CreditAttribution: recidive commented 20 September 2011 at 16:35

Confirmed, installing through install.php installer works fine.

Log in or register to post comments

Comment #13

febbraro CreditAttribution: febbraro commented 20 September 2011 at 17:01

The difference b/w a drush si and install.php is that install.php uses the batch api for the modules installs so it must be a cache thing I'm thinking....

Log in or register to post comments

Comment #14

recidive CreditAttribution: recidive commented 20 September 2011 at 17:05

@febbraro: makes sense. Is there anything I can try?

Since the issue is assigned to yourself, can I assume you're looking at fixing this problem?

Thanks!

Log in or register to post comments

Comment #15

febbraro CreditAttribution: febbraro commented 20 September 2011 at 22:58

Assigned:

febbraro

» Unassigned

Log in or register to post comments

Comment #16

febbraro CreditAttribution: febbraro commented 20 September 2011 at 23:13

I just ran through your install profile exactly as you detailed in #11 and everything installed cleanly without errors.

Log in or register to post comments

Comment #17

febbraro CreditAttribution: febbraro commented 20 September 2011 at 23:31

File	Size
features-1187858-17.patch	1.86 KB

@recidive I ran through and think I reliably reproduced your error. Can you try the attached patch and let me know if this fixes your problem?

Log in or register to post comments

Comment #18

febbraro CreditAttribution: febbraro commented 20 September 2011 at 23:35

@smk-ka: committed your patch in #1 to 7.x branch. http://drupalcode.org/project/features.git/commit/b82b16d

Log in or register to post comments

Comment #19

febbraro CreditAttribution: febbraro commented 21 September 2011 at 00:21

Status:

Needs review

» Fixed

Also committed patch in #17 as it was a regression from an earlier patch.

Going to close this and move recidive's problem to another issue.

Log in or register to post comments

Comment #20

attiks CreditAttribution: attiks commented 21 September 2011 at 06:49

FYI I just tested with latest dev version with recidive's test module in #11 and it's working, also backlinking to #1265168: Rebuild the file list properly when a feature is enabled or disabled

Log in or register to post comments

Comment #21

smk-ka CreditAttribution: smk-ka commented 21 September 2011 at 12:20

Assigned:

febbraro

» Unassigned

File	Size
features-1187858.patch	1.37 KB

Hm, I had to clear the static caches altogether to be able to install cleanly. Attached patch is IMO the most robust solution. And thanks for the install profile, @febbraro!

Log in or register to post comments

Comment #22

febbraro CreditAttribution: febbraro commented 21 September 2011 at 14:27

@smk-ka you had to remove all static caches to install the profile from #11 cleanly? I did not have to do that for a clean install.

@recidive, does this patch help you with your other profile problem?

Log in or register to post comments

Comment #23

recidive CreditAttribution: recidive commented 21 September 2011 at 14:29

@attiks: thanks, I forgot to say that was working in my comment.

@smk-ka: I tested your patch in #21, and the MartPlug install completes but with some warnings and I get a broken install with errors and missing stuff. Any clues?

$ drush si martplug
You are about to DROP your 'martplug_beta_test11' database and then CREATE a new one. Do you want to continue? (y/n): y
Starting Drupal installation. This takes a few seconds ...                                          [ok]
WD theme: Theme key "link_formatter_link_default" not found.                                        [warning]
WD theme: Theme key "image_formatter" not found.                                                    [warning]
WD theme: Theme key "link_formatter_link_default" not found.                                        [warning]
WD theme: Theme key "image_formatter" not found.                                                    [warning]
WD theme: Theme key "link_formatter_link_default" not found.                                        [warning]
WD theme: Theme key "image_formatter" not found.                                                    [warning]
WD theme: Theme key "image_formatter" not found.                                                    [warning]
WD theme: Theme key "image_formatter" not found.                                                    [warning]
WD theme: Theme key "image_formatter" not found.                                                    [warning]
A Display Suite code text format has been created.                                                  [status]

Log in or register to post comments

Comment #24

smk-ka CreditAttribution: smk-ka commented 21 September 2011 at 15:15

@febbraro Yes, without clearing all static caches, drush outputs the following notices (may need to use verbose output – -v option):

Undefined index: delete terms in 1 features.user.inc:88                 [notice]
Undefined index: edit terms in 1 features.user.inc:88                   [notice]

@recidive I know those errors from my own features, but wouldn't say they're related to this one, so better create a new issue.

Log in or register to post comments

Comment #25

recidive CreditAttribution: recidive commented 21 September 2011 at 15:18

Status:

Needs review

» Needs work

@smk-ka: I wonder if we should move this issue to drush queue, It looks like we are trying to do something impossible here.

Log in or register to post comments

Comment #26

mrfelton CreditAttribution: mrfelton commented 30 November 2011 at 19:19

The patch in #21 resolved my issue in #1357262: Unable to include feature that contains a bean type in an installation profile which seems to be related #1063204: Adding a new permission causes integrity constraint violation.

Log in or register to post comments

Comment #27

mrfelton CreditAttribution: mrfelton commented 6 December 2011 at 11:47

File	Size
1187858.27-features.patch	1.34 KB

Patch from #21 is the only things that gets things (semi) working for me at the moment. This version (which is exactly the same) applies cleanly against 7.x-1.x using drush make.

Log in or register to post comments

Comment #28

smk-ka CreditAttribution: smk-ka commented 6 December 2011 at 15:47

Just a heads-up: while this patch fixes the node permissions import, it introduces a new bug, which results in the features admin UI to appear unstyled (or at least with some styles missing). This happens due to calling drupal_static_reset() without argument clearing out all statically cached CSS files that have been added on the page so far. However, I wasn't able to find the static caches that actually need to be cleared, therefore I can't offer a better solution ATM.