filefield_get_file_reference_count() is too slow [#1189932]

filefield_get_file_reference_count() counts references. If I understand the API right, we only need to report if there are any references, exact number doesn't matter. Thus we must be able to use range query with LIMIT 1
instead of COUNT which is painfully slow on innodb.

Comment	File	Size	Author
#2	filefield_get_file_reference_count_1189932.patch	2.36 KB	crea

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

crea CreditAttribution: crea commented 16 June 2011 at 12:09

Approach is already implemented in D7
http://drupal.org/node/747464

Comment #2

crea CreditAttribution: crea commented 16 June 2011 at 14:12

Status:

Active

» Needs review

File	Size
filefield_get_file_reference_count_1189932.patch	2.36 KB

Comment #3

quicksketch

he/him

CreditAttribution: quicksketch commented 16 June 2011 at 19:54

Hmm, I don't know about this. This is a pretty major change to the API that has existed for almost 3 years, I don't think we can change it at this point to have a different return value. Who knows how other modules have been using these functions?

Comment #4

crea CreditAttribution: crea commented 16 June 2011 at 20:52

We can keep this function, but implement a copy with a different name which uses the new approach, and use it everywhere in this module (such as inside hook_file_references()). It's then a problem in calling module, if it calls the old function.