On my site, we use comment notify only with anonymous users and handle authenticated user/author/admin notifications using other means (e.g., subscriptions, Rule triggers). We use the 'subscribe to comments' permission to determine who gets the comment_notify UI.

Unfortunately, this doesn't work for roles with admin access to the comments (e.g., moderators), because comment_notify uses 'administer comments' permission to determine who gets access to it.

Patch included.

CommentFileSizeAuthor
comment_notify-permissions.patch850 byteslirazsiri
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Active » Needs work

Thanks for the issue and patch.

The idea of this permission check is that when an admin modifies someone else's comment they can see and edit the subscription status.

We could change that check to add a test for whether they are editing a comment that is NOT by them and they have administer comments permission.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented

Hi lirazsiri, will you be able to incorporate my suggestion into your patch?

OddJob’s picture

OddJob CreditAttribution: OddJob commented

What is the status of this - does the patch need to be reworked with greggles suggestions? For 6.x and 7.x?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented
Issue summary: View changes
Status: Needs work » Closed (outdated)

6.x is no longer supported and in my review I believe this does not affect 7.x, so marking as outdated. If this issue is still relevant for 7.x, please reopen.