In my case for nodes

CommentFileSizeAuthor
#7 modules-list.zip1.61 KBcarlos.macao
#1 page_title.patch819 bytesakor
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

akor’s picture

Status: Active » Needs review
FileSize
819 bytes

This is my patch, which helped me.

nicholasThompson’s picture

What are you trying to do here?

carlos.macao’s picture

This is an urgent issue. I've tried all the versions for D7 but the problems remains. This affects SEO!

nicholasThompson’s picture

Priority: Critical » Normal
Status: Needs review » Postponed (maintainer needs more info)

I honestly have no idea what this issue is about. I cant even figure out what the patch is trying to do (it looks like its trying to use the Pattern for the title?!)

carlos.macao’s picture

In my case I did not tried any patch. I have the same problem using D7 version. I've tried several Page Tittle versions. The patterns aren't replaced and they are showed in a literal way. I've deactivate the module, for now. What modules could be influencing Page Tittle? This issue has started recently.

nicholasThompson’s picture

Sorry, I will need *far* more information than this.

I assume, by "literal", you mean the tokens are not being replaced? Do you have the Token module? Which versions (of everything) are you running? Any errors Watchdog? What pattern have you configured and for which pattern type?

carlos.macao’s picture

FileSize
1.61 KB

1-Yes the tokens are not being replaced.
2-I have the Token module and I've tried both versions: 7.x-1.0-beta2 and 7.x-1.x-dev.
3-Well the list is a bit long. Look to the attachment please.
4-The only error I have is: Deprecated function: Call-time pass-by-reference has been deprecated em drupal_load() (linha 932 de /usr/home/formacao/www/includes/bootstrap.inc).
5-Pattern, the default ones: [current-page:page-title] | [site:name]

Site:

carlos.macao’s picture

Sorry, but after uninstalling all the modules I've discovered the culprit: Feature Content has a bug which prevents jquery to load correctly. There is a patch I've already installed. Now everything is all right.

nicholasThompson’s picture

Status: Postponed (maintainer needs more info) » Closed (works as designed)

Closing

akor’s picture

Status: Closed (works as designed) » Active

I have custom title for some nodes, which I wrote by hands. Then, I decide to use title pattern for other nodes. Once I input pattern, all my custom titles were replaced by pattern. I hope problem is clear now?

I open this bug for while. Thank you in advance.

Michsk’s picture

This is still a bug.

When you set page title patterns for let's say node-types. But then have a specific node where you manually change the page title. It does not overwrite the page title for that node but uses the pattern instead.

looklively’s picture

I can confirm this behaviour.
The default pattern is used instead of the custom title added to a specific node.

Subscribing.

Agogo’s picture

Status: Postponed (maintainer needs more info) » Active

Major bug.
I have the same problem and with the latest D7 version. Pattern is used instead of custom title entered to the node in question. Breaks SEO quite alot.

EDIT:
The function page_title_page_get_title on line 599 in page_title.module doesnt seem to load the custom variable at all. The hook_node_load function on line 359 in page_title.module works as it should but doesnt affect anything.

I dont really get when or where in the code the page title for a node is supposed to be set if its entered manually for each node...

nicholasThompson’s picture

Version: 6.x-2.3 » 7.x-2.7
Priority: Normal » Major
Status: Active » Postponed (maintainer needs more info)

This is completely a misunderstanding of how the module works.

The pattern defines the structure for the page title for ALL nodes of that type. *All Nodes*.

The Page Title field on the node allows you to define the "page-title" token (which will default to the node title if not set). This means you can have one title for linking/displaying (node title) and another for SEO/SERP pages (Page Title). The pattern can make use of this token in a structured way.

There is no way to define a pattern for all types and another for an individual node. If you have different patterns for different nodes, just set the pattern to use the Page Title token and hard-code your title on a per-node basis.

If there is a need for a per-node pattern (which I'm not sure is necessary, with the right planning), then this should be a separate feature request... However I think that would add another level of complexity to the module which shouldn't really be necessary.

Agogo’s picture

Status: Active » Postponed (maintainer needs more info)

I think Im confused now after your post. What is it that the custom field in nodes is supposed to do?

Im using it to enter a custom Page Title - without tokens, on some pages where the pattern shouldnt apply. It doesnt load anywhere. Which is why I beleive theres a bug somewhere.

EDIT:
Nevermind, now I get what the specific field for each node is supposed to do. Sorry for the misunderstanding. It felt logical that the field was an override and I guess Im not the first to do the same mistake.

My problem is that Im not using the node title as pattern for this particular node type - Im using the menu title. So I cant override the Page Title for those nodes in any way...

But youre right, it IS a completely new function. Sorry again.

marty.true’s picture

This is completely a misunderstanding of how the module works.

The pattern defines the structure for the page title for ALL nodes of that type. *All Nodes*.

The Page Title field on the node allows you to define the "page-title" token (which will default to the node title if not set). This means you can have one title for linking/displaying (node title) and another for SEO/SERP pages (Page Title). The pattern can make use of this token in a structured way.

There is no way to define a pattern for all types and another for an individual node. If you have different patterns for different nodes, just set the pattern to use the Page Title token and hard-code your title on a per-node basis.

If there is a need for a per-node pattern (which I'm not sure is necessary, with the right planning), then this should be a separate feature request... However I think that would add another level of complexity to the module which shouldn't really be necessary.

Seriously? Ok so when you named this project "page title" were you not intending that each "page" could be individually set to have a title that is relevant to it's node? If you really didn't intend for this module to work as (pretty much) everyone thinks it does, then why didn't you call this project "content type titles"? If we are talking about SEO here, which is clearly the purpose of even setting a page's meta title in the first place... Then the ability to custom set a single node's title is what we need, not the ability to set a token for ALL nodes of a certain content type.

As far as I'm concerned, this IS a major bug and unless it is resolved, it does not do anything helpful to SEO'ing a single node.

emi_bcn’s picture

Issue summary: View changes

As far as I'm concerned, this IS a major bug and unless it is resolved, it does not do anything helpful to SEO'ing a single node.

Again, you misundertand that, on the global pattern, you can add the actual page (node, term, user, ...) title to the pattern. So, for example, you can have a pattern for users like [current-page:page-title] | Users | [site:name]. Or a taxonomy pattern like [current-page:page-title] | Terms | [site:name]. Or Articles content type as [current-page:page-title] | Articles | [site:name]

bsqtmp’s picture

The Problem is if you are using page_titel and metatags modul this problem occurs.
If you are using metatags to make individual Titles disable page_titel and then it works fine....