Gallery List defies i18n [#1193832]

Comment	File	Size	Author
#7	1193832-gallery-list-title.patch	1.22 KB	scroogie
	Gallery List P2.PNG	27.31 KB	dddave
	Gallery List P1.PNG	63.89 KB	dddave

Comment #1

dddave CreditAttribution: dddave commented 20 June 2011 at 10:45

This problem doesn`t occur with "My Galleries" which translates as expected to "Meine Galerien". What makes "Gallery list" so special?

Log in or register to post comments

Comment #2

justintime CreditAttribution: justintime commented 20 June 2011 at 14:08

Well, I think I have an idea on how to fix it, but I can't for the life of me explain why "My Galleries" is translating but "Gallery List" is not. I hate to ask this, but you have cleared all caches a time or two, right?

Log in or register to post comments

Comment #3

dddave CreditAttribution: dddave commented 20 June 2011 at 15:02

I flushed like a pro. ;)

Could it be that the fact that we tie the Gallery list view to a certain url collides with how languages are negotiated?

I am going to test some different set-ups and report back.

Edit: tested different settings for content selection and language negotiation but to no avail. BUT I can confirm that the conflict stems from the fact that the view is tied to the /galleries url. Changing the view to display at /galleries to the "My galleries" display breaks the latter too (which works perfectly when visiting from the "My Galleries" link).

Log in or register to post comments

Comment #4

justintime CreditAttribution: justintime commented 20 June 2011 at 14:56

Hmm, out of curiosity, what happens when you comment out line 135 in node_gallery.pages.inc? It's the one that calls drupal_set_title().

Log in or register to post comments

Comment #5

dddave CreditAttribution: dddave commented 20 June 2011 at 15:17

Commenting out the line seems to help. The correct title is displayed (side-effect: NG now ignores the setting which display to use at /galleries and always uses the gallery list display.

Did you see my edit in #3?

Log in or register to post comments

Comment #6

justintime CreditAttribution: justintime commented 29 June 2011 at 04:20

Category:

support

» bug

@scroogie is more i18n knowledgeable than I am -- perhaps he can weigh in on this one?

Log in or register to post comments

Comment #7

scroogie CreditAttribution: scroogie commented 30 June 2011 at 09:30

Status:

Active

» Needs review

File	Size
1193832-gallery-list-title.patch	1.22 KB

The simple explanation is that drupal_set_title does not translate the titles. views_get_view just loads the View, it does not execute it, thus the title is untranslated here as well. So a simple fix is to change it to

drupal_set_title(t($title));

The problem is that this is user input, so we should check_plain() or filter_xss() or something.

To be honest, I'm not really convinced that this is the right way for setting the title, as it's hidden in the Views UI instead of being in the NG UI, but I already wrote that in #1043532 and we discuss it for the next version.

Log in or register to post comments

Comment #8

dddave CreditAttribution: dddave commented 30 June 2011 at 17:14

Applied the patch and it seems to fix the problem.

Log in or register to post comments

Comment #9

justintime CreditAttribution: justintime commented 2 July 2011 at 03:28

Just a note here that I'm not wanting to commit this until we get #1043532: Breadcrumbs use hardcoded strings instead of menu entries resolved. It's close, and I have a feeling that the outcome there will perhaps impact this issue as well.