Incorrect handling of multi-part paths [#1194896]

Comment	File	Size	Author
#21	incorrect-multi-path-1194896.patch	4.38 KB	valthebald
#7	1194896-load-only-entities.patch	524 bytes	valthebald

Comment #1

moonpool CreditAttribution: moonpool commented 21 June 2011 at 10:12

I get the same with the alpha-3 release

Log in or register to post comments

Comment #2

JOINSO CreditAttribution: JOINSO commented 21 June 2011 at 10:41

There is no problem with another Panel Pages.
In my case the problem is in a Panel Page with a View block inside...
Is your case?

Regards!

Log in or register to post comments

Comment #3

JOINSO CreditAttribution: JOINSO commented 21 June 2011 at 17:52

Hi!

I just make some debuggin on the module and i find this.

$keys is never defined in Panel Pages (almost in my case).

And why some Panel Pages works and others no?

The problem is that function:

_metatags_quick_fieldable that returns an array in some Panel Pages and a empty one in anothers....

When return the empty one everything goes fine, but not when returns with the type...., because found after the problem with $key....

I'm going to continue studying to find the underlying problem....

Regards!

Log in or register to post comments

Comment #4

JOINSO CreditAttribution: JOINSO commented 21 June 2011 at 18:09

Hi!.....

When i'm debugging i see a special behaviour:

In the case of a Panel Page with a View block inside, the function
_metatags_quick_fieldable is called first with type "node". In this case we see the error of the issue....

In a Panel Page without a View block inside...., _metatags_quick_fieldable is never called with type "node" ....

Any idea?

Regards!

Log in or register to post comments

Comment #5

john.oltman CreditAttribution: john.oltman commented 25 June 2011 at 02:25

I get this in both alpha3 and dev, immediately after installing the module into a fresh 7.2 site. It appears at the top of the module list page. I've not defined any meta tag fields yet, just enabled the module and got the notice.

Log in or register to post comments

Comment #6

JOINSO CreditAttribution: JOINSO commented 25 June 2011 at 16:13

I think that the problem is in Views, exactly with this function:
$keys = array_keys($router_item['load_functions']);

Where is any page with views inside, the module are called more than one time.... at least one for the page and another for the view.... and the fails....

Regards!

Log in or register to post comments

Comment #7

valthebald

Sofia

CreditAttribution: valthebald commented 25 June 2011 at 17:25

Status:

Active

» Needs review

File	Size
1194896-load-only-entities.patch	524 bytes

I wanted to include that with other changes to the next release, but seems there are too many problems with this issue.

In metatags_quick_page_build() function menu object must be loaded, only if current page is an entity view page
(which is not the case).
Please use attached patch (or change line 185 from

if (!$fieldable_entity) {

to

if ($object_loadable && !$fieldable_entity) {

Log in or register to post comments

Comment #8

john.oltman CreditAttribution: john.oltman commented 25 June 2011 at 17:46

Status:

Needs review

» Reviewed & tested by the community

#7 worked for me, thanks much

Log in or register to post comments

Comment #9

JOINSO CreditAttribution: JOINSO commented 25 June 2011 at 18:37

Hi!
THis patch only avoids the problem....
But in this cases, the meta tags doesn't show.....

Regards!

Log in or register to post comments

Comment #10

amanaplan CreditAttribution: amanaplan commented 26 June 2011 at 15:51

subscribing

Log in or register to post comments

Comment #11

valthebald

Sofia

CreditAttribution: valthebald commented 26 June 2011 at 20:19

Version:	7.x-2.x-dev	» 7.x-2.0-alpha4
Assigned:	Unassigned	» valthebald
Status:	Reviewed & tested by the community	» Fixed

Log in or register to post comments

Comment #12

JOINSO CreditAttribution: JOINSO commented 26 June 2011 at 20:30

Status:

Fixed

» Active

Hi, valthebald....

I'ts not fixed, in that cases when the error is present (keys not defined), meta tags are not showed.

Regards!

Log in or register to post comments

Comment #13

valthebald

Sofia

CreditAttribution: valthebald commented 27 June 2011 at 04:07

In alpha4 there is no 'keys' check. On what line do you get an error?

Log in or register to post comments

Comment #14

JOINSO CreditAttribution: JOINSO commented 27 June 2011 at 07:25

In normal Panel pages, meta tags works normal, but when i have a Panel Page, with a View block inside, then it seems that the module tries to check meta tags for the view..... in this case, meta tags are not showed.

Here is the page that doesn't work: http://beta.bicisprint.com/es/club/noticias/
and here one that works: http://beta.bicisprint.com/es/club/

Regards!

Log in or register to post comments

Comment #15

valthebald

Sofia

CreditAttribution: valthebald commented 27 June 2011 at 14:36

Status:

Active

» Postponed (maintainer needs more info)

I've tried to do the same - views block inside panels page. Worked fine.
Need more info, could not reproduce

Log in or register to post comments

Comment #16

moonpool CreditAttribution: moonpool commented 27 June 2011 at 20:53

alpha-4 has fixed this for me

Log in or register to post comments

Comment #17

JOINSO CreditAttribution: JOINSO commented 27 June 2011 at 21:40

Ok, tomorrow i will try alpha-4 and make some tests.
Regards!

Log in or register to post comments

Comment #18

JOINSO CreditAttribution: JOINSO commented 28 June 2011 at 10:07

Doesn't work alpha-4

This works: http://beta.bicisprint.com/club/

and this doesn't work:

http://beta.bicisprint.com/es/club/noticias/

Regards!

Log in or register to post comments

Comment #19

valthebald

Sofia

CreditAttribution: valthebald commented 28 June 2011 at 11:18

Version:	7.x-2.0-alpha4	» 7.x-2.x-dev
Status:	Postponed (maintainer needs more info)	» Active

Ok, I managed to reproduce the problem. Most chance it comes from double URL-escaping of the path ('club/noticias') - first it is transformed to club%2Fnoticias, and then to club%25252noticias.
This is a definite bug, patch coming later

Log in or register to post comments

Comment #20

JOINSO CreditAttribution: JOINSO commented 28 June 2011 at 16:22

Thanks, valthebald!
We wait for the patch!
Regards!

Log in or register to post comments

Comment #21

valthebald

Sofia

CreditAttribution: valthebald commented 2 July 2011 at 09:50

Title:	Undefined variable: keys in metatags_quick_page_build()	» Incorrect handling of multi-part paths
Status:	Active	» Fixed
Issue tags:		+Path based meta tags

File	Size
incorrect-multi-path-1194896.patch	4.38 KB

Log in or register to post comments

Comment #22

JOINSO CreditAttribution: JOINSO commented 4 July 2011 at 10:48

Hi, valthebald!
The patch doesn't work for me.

When i'm on the Panel Page, i see "Meta Tags (quick) settings" link, and when i click i go to Config for Meta tags, no to edit the meta tags of the Panel Page....

Regards!

Log in or register to post comments

Comment #23

valthebald

Sofia

CreditAttribution: valthebald commented 4 July 2011 at 10:52

You absolutely need to clean drupal cache after applying the patch. "Meta Tags (quick) settings" link means that menu system does not see (updated) menu handlers