If a field which can be split into body and summary has multiple label elements (added by a module for whatever reason), additional "Edit/Hide summary" links appear and more appear when these links are clicked. The solution is a tiny change to the jQuery selector to ensure that it only adds the link to one label element.

Files: 
CommentFileSizeAuthor
#19 text-edit-hide-summary-links.patch762 bytesLiam Morland
PASSED: [[SimpleTest]]: [MySQL] 40,734 pass(es).
[ View ]
#14 text-edit-hide-summary-links.patch709 bytesLiam Morland
PASSED: [[SimpleTest]]: [MySQL] 58,022 pass(es).
[ View ]
#13 core_url_alias_unique_925474.patch1.5 KBLiam Morland
PASSED: [[SimpleTest]]: [MySQL] 57,915 pass(es).
[ View ]
#12 text-edit-hide-summary-links.patch709 bytesLiam Morland
PASSED: [[SimpleTest]]: [MySQL] 53,968 pass(es).
[ View ]
#6 text-edit-hide-summary-links.patch765 bytesLiam Morland
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch text-edit-hide-summary-links_0.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#3 text-edit-hide-summary-links.patch782 bytesLiam Morland
PASSED: [[SimpleTest]]: [MySQL] 34,392 pass(es).
[ View ]
text-edit-hide-summary-links.patch762 bytesLiam Morland
PASSED: [[SimpleTest]]: [MySQL] 33,495 pass(es).
[ View ]

Comments

The patch above fixes this issue in both D7 and D8.

Status:Active» Needs review

Version:7.x-dev» 8.x-dev
StatusFileSize
new782 bytes
PASSED: [[SimpleTest]]: [MySQL] 34,392 pass(es).
[ View ]

Updated patch rolled against latest D8.

Status:Needs review» Needs work

The last submitted patch, text-edit-hide-summary-links.patch, failed testing.

Status:Needs work» Needs review

#3: text-edit-hide-summary-links.patch queued for re-testing.

StatusFileSize
new765 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch text-edit-hide-summary-links_0.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Updated patch rolled against latest D8.

#6: text-edit-hide-summary-links.patch queued for re-testing.

#6: text-edit-hide-summary-links.patch queued for re-testing.

Issue tags:+JavaScript

Looks good to me, doesn't seem to break anything either. Tagging with Javascript. Seutje or nod_ (or anyone else, could you guys RTBC this then ?

Issue tags:-JavaScript

#6: text-edit-hide-summary-links.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+JavaScript

The last submitted patch, text-edit-hide-summary-links.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new709 bytes
PASSED: [[SimpleTest]]: [MySQL] 53,968 pass(es).
[ View ]

Reroll.

StatusFileSize
new1.5 KB
PASSED: [[SimpleTest]]: [MySQL] 57,915 pass(es).
[ View ]

Sorry, this is not the right file.

StatusFileSize
new709 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,022 pass(es).
[ View ]

Reroll.

Component:field system» text.module

Moving to text.module - there might be other text issues in the 'field system' component.

Status:Needs review» Reviewed & tested by the community

pretty straight-forward

Status:Reviewed & tested by the community» Fixed

Committed 0284fcf and pushed to 8.x. Thanks!

Version:8.x-dev» 7.x-dev
Status:Fixed» Patch (to be ported)

Status:Patch (to be ported)» Needs review
StatusFileSize
new762 bytes
PASSED: [[SimpleTest]]: [MySQL] 40,734 pass(es).
[ View ]

D7 version.