Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Liam Morland’s picture

Status: Active » Needs review
FileSize
5.44 KB

Here is the linked patch ported to the Accessible Fix Module.

johnbarclay’s picture

I changed this a little so the css was easier to get rid of when the issue is fixed in core. Revised patch is applied and in head. I'm leaving this as needs review until tested more.

johnbarclay’s picture

this creates 2 issues:

# Notice: Undefined index: #type in accessible_fix_form_element() (line 439 of E:\inetpub\wwwroot\Drupal\d7win\drupal7_root\sites\all\modules\accessible\accessible_fix\accessible_fix.module).
# Notice: Undefined index: #children in accessible_fix_form_element() (line 457 of E:\inetpub\wwwroot\Drupal\d7win\drupal7_root\sites\all\modules\accessible\accessible_fix\accessible_fix.module).

and breaks all the checkboxes in the modules list page. Can you run it with strict on the php and write a simpletest for it or otherwise verify it works.

I've pulled it out of head for now.

Liam Morland’s picture

Thanks. Attached is an updated patch, based on yours, which clears the notices you mention. The second patch clears other strict notices I was getting, unrelated to my patch.

Liam Morland’s picture

Also, the modules list page works for me with this patch.

Liam Morland’s picture

Here is a new version of the patch that applies the fix to theme_webform_element() as well as to theme_form_element.

erynn’s picture

I applied the most recent patch (the others would not apply properly) and when I selected a option in the Accessible Config menu, I got the error: PHP Fatal error: require_once(): Failed opening required 'module_fixes/webform.admin.inc'. Do you have an admin.inc file for webform?

Liam Morland’s picture

No, my changes don't change anything about the admin interface, so I thought the file could be omitted.

mfairchild365’s picture

I re-rolled the patch to work with the latest commits to the 7.x-2.x branch

mfairchild365’s picture

Eric_A’s picture

Here's a reroll of #10 to bring the webform theme function code up to date as far as webform-7.x-4.10. I'll try to do an update to more recent versions later.

Eric_A’s picture

And here's a patch that brings in #284431: Add option to place descriptions above fields (Introduced with webform-7.x-4.11).