Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
See latest patch here - http://drupal.org/node/504962#comment-4627448
Comment | File | Size | Author |
---|---|---|---|
#12 | accessible-fix-fieldset-1195418-12.patch | 10.13 KB | Eric_A |
#12 | interdiff.txt | 2.18 KB | Eric_A |
#11 | accessible-fix-fieldset-1195418-11.patch | 9.72 KB | Eric_A |
#11 | interdiff.txt | 4.59 KB | Eric_A |
#10 | accessible-webform-1195418-update-7.x-2.x.patch | 10.76 KB | mfairchild365 |
Comments
Comment #1
Liam MorlandHere is the linked patch ported to the Accessible Fix Module.
Comment #2
johnbarclay CreditAttribution: johnbarclay commentedI changed this a little so the css was easier to get rid of when the issue is fixed in core. Revised patch is applied and in head. I'm leaving this as needs review until tested more.
Comment #3
johnbarclay CreditAttribution: johnbarclay commentedthis creates 2 issues:
# Notice: Undefined index: #type in accessible_fix_form_element() (line 439 of E:\inetpub\wwwroot\Drupal\d7win\drupal7_root\sites\all\modules\accessible\accessible_fix\accessible_fix.module).
# Notice: Undefined index: #children in accessible_fix_form_element() (line 457 of E:\inetpub\wwwroot\Drupal\d7win\drupal7_root\sites\all\modules\accessible\accessible_fix\accessible_fix.module).
and breaks all the checkboxes in the modules list page. Can you run it with strict on the php and write a simpletest for it or otherwise verify it works.
I've pulled it out of head for now.
Comment #4
Liam MorlandThanks. Attached is an updated patch, based on yours, which clears the notices you mention. The second patch clears other strict notices I was getting, unrelated to my patch.
Comment #5
Liam MorlandAlso, the modules list page works for me with this patch.
Comment #6
Liam MorlandHere is a new version of the patch that applies the fix to theme_webform_element() as well as to theme_form_element.
Comment #7
erynn CreditAttribution: erynn commentedI applied the most recent patch (the others would not apply properly) and when I selected a option in the Accessible Config menu, I got the error: PHP Fatal error: require_once(): Failed opening required 'module_fixes/webform.admin.inc'. Do you have an admin.inc file for webform?
Comment #8
Liam MorlandNo, my changes don't change anything about the admin interface, so I thought the file could be omitted.
Comment #9
mfairchild365 CreditAttribution: mfairchild365 commentedI re-rolled the patch to work with the latest commits to the 7.x-2.x branch
Comment #10
mfairchild365 CreditAttribution: mfairchild365 commentedThis patch fixes the issue reported in https://drupal.org/comment/4704796#comment-4704796
Comment #11
Eric_A CreditAttribution: Eric_A commentedHere's a reroll of #10 to bring the webform theme function code up to date as far as webform-7.x-4.10. I'll try to do an update to more recent versions later.
Comment #12
Eric_A CreditAttribution: Eric_A commentedAnd here's a patch that brings in #284431: Add option to place descriptions above fields (Introduced with webform-7.x-4.11).