unknown storage type when used in an install profile [#1196432]

When working with a installation profile workflow, or building a distribution it's impossible to control the default field storage. At least in a sane way :)

If one do like this in settings.php...

  $conf['field_storage_default'] = 'field_sql_storage';

...it will be overwritten when the profile is installed. It will be overwritten in mongodb_field_storage_install(). Any fields defined in the install profile (or in Features modules) after that will get mongodb_field_storage as the field storage. And that might not always be what you want.

So I suggest that we let it be up to the user to decide what should be default storage. That sounds better to me at least :)

Attached is a patch that fixes this, and also adds a note in README.txt on how this is configured. The tests should not need an update since they already have:

  function setUp() {
    parent::setUp(array('mongodb', 'mongodb_field_storage', 'field_test'));
    variable_set('field_storage_default', 'mongodb_field_storage');
    // ...
  }

Comment	File	Size	Author
#8	storage_type-1196432-8.patch	629 bytes	langworthy
#8
	mongodb-dont-set-default-storage.patch	1.21 KB	dixon_

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

22 June 2011 at 12:12

Status:

Needs review

» Needs work

The last submitted patch, mongodb-dont-set-default-storage.patch, failed testing.

Comment #2

dixon_

he/him

English

France

CreditAttribution: dixon_ commented 22 June 2011 at 12:15

Status:

Needs work

» Active

I'm not sure why the tests are failing. To me it seems like the tests should not need an update due to the changes in this patch. But I might be wrong?

I will look some more into this.

Comment #3

langworthy CreditAttribution: langworthy commented 28 June 2012 at 20:08

I'm following the current instructions in the README which say to add the following to settings.php $conf['field_storage_default'] = 'mongodb_field_storage';. This is similar to what the patch above uses.

When installing a new custom profile that includes mongodb_field_storage.module I get the following error.

WD php: FieldException: Attempt to create a field with unknown storage type mongodb_field_storage. in field_create_field() (line 126 of                          [error]
.../modules/field/field.crud.inc).

Comment #4

chx CreditAttribution: chx commented 29 June 2012 at 00:47

Title:	Don't set 'field_storage_default' upon installation	» unknown storage type when used in an install profile
Category:	feature	» bug

This is a bug report I am gladly accepting patches for. Removing hook_install is not something I am going to consider, sorry.

Comment #5

phayes CreditAttribution: phayes commented 29 June 2012 at 16:52

I've found that putting the following in my install profile seems to fix it:

module_enable(array('mongodb_field_storage'));
drupal_flush_all_caches();

The flush-all-caches seems to fix the problem. Note that the above needs to be run before enabling any feature modules or other modules that create fields.

Active

» Needs review

File	Size
storage_type-1196432-8.patch	629 bytes

I found it easier to include the code from #5 in hook_install as long as I didn't enable the module in the .info and removed the relevant $conf variable from settings.php