Errors generated by nodequeue when trying to update old data [#1199480]

After upgrading to alpha2 the following errors occur on several pages including the clear cache page:

***********
Notice: Undefined offset: 1 in nodequeue_handler_relationship_nodequeue->init() (line 18 of /var/www/resilient/sites/all/modules/nodequeue/includes/views/nodequeue_handler_relationship_nodequeue.inc).
***********

Several views that contained relationships to older nodequeue releases also spawned errors. (see http://drupal.org/node/1199370) After deleting and reinserting these relationships and fields, many of the original errors disappeared, but some still remain even when all views have relationships to nodequeue removed.

Comment	File	Size	Author
#7	nodequeue-viewshandlerwarnings-1199480-7.patch	701 bytes	ronan
#7
#6	1199480.patch	776 bytes	amateescu
#6

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

zoon_unit CreditAttribution: zoon_unit commented 25 June 2011 at 20:36

Note that I can "cure" this particular error by reinstalling the nodequeue module through the devel module. (which deletes the old tables and creates them anew)

This tells me that the update code for alpha 2 is missing the update and conversion of something in the old tables.

Comment #2

Andreas Radloff CreditAttribution: Andreas Radloff commented 1 July 2011 at 18:04

I'm seeing the same error (but with Undefined offset: 2). I'm using an older dev from May 19th, before alpha2, which I guess means the problem is not caused by alpha2.

I'm currently on views 7.x-3.0-rc1 but the problem has existed for me since a couple of months, everything seems to be working except for the notices.

Comment #3

amateescu CreditAttribution: amateescu commented 10 July 2011 at 20:00

This notice was introduced in http://drupal.org/node/817558#comment-4453848.

I will try to provide a fix in the following days.

Comment #4

amateescu CreditAttribution: amateescu commented 21 July 2011 at 20:05

Version:	7.x-2.0-alpha2	» 7.x-2.x-dev
Status:	Active	» Postponed (maintainer needs more info)

Can you please give me the output of:

debug($map);
debug($options['qids']);

right after:

$map = array_flip(nodequeue_get_qid_map());

Comment #5

amateescu CreditAttribution: amateescu commented 18 September 2011 at 17:46

Status:

Postponed (maintainer needs more info)

» Closed (cannot reproduce)

Please reopen if you can provide more info.

Comment #6

amateescu CreditAttribution: amateescu commented 15 October 2011 at 23:22

Status:

Closed (cannot reproduce)

» Closed (fixed)

File	Size
1199480.patch	776 bytes

I was able to reproduce this issue and commited the attached patch to fix it.

http://drupalcode.org/project/nodequeue.git/commit/19747f2

Comment #7

ronan CreditAttribution: ronan commented 8 May 2013 at 21:34

Status:

Closed (fixed)

» Needs review

File	Size
nodequeue-viewshandlerwarnings-1199480-7.patch	701 bytes

I'm having something similar with the latest dev (2013-Apr-10). Not sure what's causing it, but the $value is valid but the $map[$key] does not exist, therefore I'm getting the same warning as above. The attached patch expands the guard clause from #6 to deal with this.

Comment #8

mycrazydog CreditAttribution: mycrazydog commented 3 September 2014 at 13:49

Issue summary:

View changes

Just for anyone who encounters this problem too (Undefined offset / nodequeue_handler_relationship_nodequeue), this patch fixed the problem for me. Thanks