Multi-level breaks are difficult to grok. PHP 5.3 introduces the goto statement as a cleaner alternative: http://php.net/manual/en/control-structures.goto.php

There are three places in core where we use multi-level breaks. I have replaced all of them with gotos and the code is now much cleaner.

Files: 
CommentFileSizeAuthor
no-multi-level-breaks.patch3.07 KBjbrown
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: failed to enable simpletest module.
[ View ]

Comments

Status:Needs review» Needs work

The last submitted patch, no-multi-level-breaks.patch, failed testing.

Does the bot need a newer APC?

Status:Needs work» Needs review

no-multi-level-breaks.patch queued for re-testing.

Status:Needs review» Needs work

The last submitted patch, no-multi-level-breaks.patch, failed testing.