Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
http://jigsaw.w3.org/css-validator/ points out several issues with Zen in both style.css and layout.css. For example, in style.css there were a couple of lines beginning "*font" -- looked like they had been uncommented and the asterisk was forgotten. Also in body, "font:x-small" should be "font-size:x-small".
Comment | File | Size | Author |
---|---|---|---|
#4 | zen_valid_css.patch | 669 bytes | add1sun |
Comments
Comment #1
rport CreditAttribution: rport commentedThis issue is also being partly worked on in another issue Terminate CSS comment in layout.css although you have also mentioned another issue regarding the
*font
which we can resolve here;Here is the code in official 5.x-0.6 version of style.css;
and here is a copy of zen.css in the development 5.x-1.x-dev version;
I suspect in both cases, the actual code should read;
Hope this helps.. Its a bit small for a patch, just a quick edit will fix it!
Russ
Comment #2
alanburke CreditAttribution: alanburke commentedHi
I think the lines
are deliberate. Its probably an IE workaround.
I think there has been talk elsewhere or having a separate ie. css file to deal with this stuff.
Alan
Comment #3
add1sun CreditAttribution: add1sun commentedyes, these are IE hacks (*property: value applies the property value in IE 7 and below.)
There is an issue to move IE hacks to their own css here: http://drupal.org/node/141784
I don't have time to run a validation check to see what else is coming up but I'll try to look at it later today.
Comment #4
add1sun CreditAttribution: add1sun commentedOK, I fixed the two errors that are not the star hacks. We'll leave the star hacks to the other issue re: IE css.
Comment #5
add1sun CreditAttribution: add1sun commentedNote: this is for 5 dev
Comment #6
JohnAlbinI’ve changed the *property hacks to either * html hacks or simplified box model hacks. Both of which validate.
And I’ve removed the *font-size line in:
…since IE doesn't seem to need to display the pre and code fonts smaller than other browsers. So I’m not sure why that line was even in there.
Comment #7
(not verified) CreditAttribution: commented