http://jigsaw.w3.org/css-validator/ points out several issues with Zen in both style.css and layout.css. For example, in style.css there were a couple of lines beginning "*font" -- looked like they had been uncommented and the asterisk was forgotten. Also in body, "font:x-small" should be "font-size:x-small".

CommentFileSizeAuthor
#4 zen_valid_css.patch669 bytesadd1sun
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rport’s picture

This issue is also being partly worked on in another issue Terminate CSS comment in layout.css although you have also mentioned another issue regarding the *font which we can resolve here;

Here is the code in official 5.x-0.6 version of style.css;

body {
  font:13px arial,helvetica,clean,sans-serif;
  *font-size:small;
  *font:x-small;
}

and here is a copy of zen.css in the development 5.x-1.x-dev version;

body {
  font:13px arial,helvetica,clean,sans-serif;
  *font-size:small;
  *font:x-small;
}

I suspect in both cases, the actual code should read;

body {
  font:13px arial,helvetica,clean,sans-serif;
}

Hope this helps.. Its a bit small for a patch, just a quick edit will fix it!

Russ

alanburke’s picture

Hi
I think the lines

  *font-size:small;
  *font:x-small;

are deliberate. Its probably an IE workaround.
I think there has been talk elsewhere or having a separate ie. css file to deal with this stuff.

Alan

add1sun’s picture

yes, these are IE hacks (*property: value applies the property value in IE 7 and below.)

There is an issue to move IE hacks to their own css here: http://drupal.org/node/141784

I don't have time to run a validation check to see what else is coming up but I'll try to look at it later today.

add1sun’s picture

Status: Active » Needs review
FileSize
669 bytes

OK, I fixed the two errors that are not the star hacks. We'll leave the star hacks to the other issue re: IE css.

add1sun’s picture

Version: 5.x-0.6 » 5.x-1.x-dev

Note: this is for 5 dev

JohnAlbin’s picture

Title: CSS does not validate - there are typos in it » zen.css does not validate
Status: Needs review » Fixed

I’ve changed the *property hacks to either * html hacks or simplified box model hacks. Both of which validate.

And I’ve removed the *font-size line in:

pre, code {
  font: 115% monospace;
  *font-size: 100%;
}

…since IE doesn't seem to need to display the pre and code fonts smaller than other browsers. So I’m not sure why that line was even in there.

Anonymous’s picture

Status: Fixed » Closed (fixed)