regcode_dynamic: features / strongarm compatibility required [#1211650]

Hi,

at the moment there is no compatibility for regcode dynamic to features / strongarm module to store settings.
Since the variables 'regcode_dynamic_settings_%', if added to a feature, are not stored in DB any more, e.g. regcode_dynamic_rules() fails.

I fixed this problem in my patch and introduced a new variable 'regcode_dynamic_rules', which holds the current rule_id's. This makes no need for any query to DB anymore.

I added an upgrade path to set this new variable initially, as well.

The patch works for me fine.

Comment	File	Size	Author
#4	regcode-1211650-4.patch	3.69 KB	TS79
#4
	regcode_dynamic_strongarm.patch	3.67 KB	TS79

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

aidanlis CreditAttribution: aidanlis commented 15 October 2011 at 11:34

Status:

Needs review

» Needs work

Love the work but your patch doesn't apply to git 6.x-2.x, could you reroll? Thanks.

Comment #2

TS79 CreditAttribution: TS79 commented 16 October 2011 at 17:10

I only can reroll the patch on versiones, which are checked into the CVS(cvs.drupal.org) since I have no expearance in creating any other patches, which work for you. (I do not use any unix env for develoment).

The 6.x-2.x I can not find in the CVS, 6.x-2.7 is checked in there...

Comment #3

aidanlis CreditAttribution: aidanlis commented 16 October 2011 at 17:27

CVS is a 20 year old version control system, Drupal now uses Git for version control.

You can see the Git repository here: http://drupalcode.org/project/regcode.git

If you're stuck on Windows then use http://code.google.com/p/tortoisegit/ perhaps.

Comment #4

TS79 CreditAttribution: TS79 commented 16 October 2011 at 20:57

Version:

6.x-2.7

» 6.x-2.x-dev

File	Size
regcode-1211650-4.patch	3.69 KB

the patch against 6.x-2.x

Comment #5

TS79 CreditAttribution: TS79 commented 16 October 2011 at 20:58

Status:

Needs work

» Needs review

Comment #6

TR CreditAttribution: TR commented 28 July 2021 at 18:42

Issue summary:	View changes
Status:	Needs review	» Closed (outdated)

Drupal 6 is no longer supported. StrongArm is an obsolete tool for current versions of Drupal, and Features is not needed for the regcode module in the current versions of Drupal because regcode settings are all in configuration management.