Block for quick backswitches use user_load in cycle just tot get uid and name.
It's bad practice and have bad perfomance impact.

I propose use single SQL query to fetch this data at once.

CommentFileSizeAuthor
#1 user-load-in-cycle-1214410-1.patch1.88 KBIRuslan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

IRuslan’s picture

IRuslan CreditAttribution: IRuslan commented
FileSize
user-load-in-cycle-1214410-1.patch1.88 KB
Nigel Cunningham’s picture

Nigel Cunningham
Location Geelong
CreditAttribution: Nigel Cunningham commented

While working on another module, I noticed that Masquerade does this a lot. Is there a reason? If not, I'll happily provide a patch to do this module-wide (or as much as possible).

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

This is a really annoying but required to allow modules a-la realname to work - override a username

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Active » Needs review

Suppose we needs more reviews

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Issue summary: View changes
Status: Needs review » Closed (outdated)

I am closing this bug report, as Drupal 6 is no longer supported. Please re-open it if the issue is still relevant for the Drupal 7 or 8 version of the module.