The book_export_html() function contains the following line:

$export_data = array();

But the $export_data variable is not referenced anywhere else in the function.
Files: 
CommentFileSizeAuthor
#8 book_export_html-remove_unused_variable-1215404-D7.patch462 bytesbrianV
PASSED: [[SimpleTest]]: [MySQL] 39,679 pass(es).
[ View ]
#3 book_export_html-remove_unused_variable-1215404-rev2.patch482 bytesbrianV
PASSED: [[SimpleTest]]: [MySQL] 46,861 pass(es).
[ View ]
#1 book_export_html-remove_unused_variable-1215404-d6.patch916 bytespillarsdotnet
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch book_export_html-remove_unused_variable-1215404-d6.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#1 book_export_html-remove_unused_variable-1215404-d7.patch916 bytespillarsdotnet
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch book_export_html-remove_unused_variable-1215404-d7_0.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#1 book_export_html-remove_unused_variable-1215404.patch916 bytespillarsdotnet
PASSED: [[SimpleTest]]: [MySQL] 33,548 pass(es).
[ View ]

Comments

Title:Remove cruft from book_export_html()Remove assignment to unused variable $export_data from book_export_html() function.
Status:Active» Needs review
StatusFileSize
new916 bytes
PASSED: [[SimpleTest]]: [MySQL] 33,548 pass(es).
[ View ]
new916 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch book_export_html-remove_unused_variable-1215404-d7_0.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
new916 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch book_export_html-remove_unused_variable-1215404-d6.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Patch.

StatusFileSize
new482 bytes
PASSED: [[SimpleTest]]: [MySQL] 46,861 pass(es).
[ View ]

Rolled to HEAD with no changes. Trivial patch, will RTBC once tests pass.

Status:Needs review» Needs work
Issue tags:-needs backport to D6, -needs backport to D7

The last submitted patch, book_export_html-remove_unused_variable-1215404-rev2.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+needs backport to D6, +needs backport to D7

Status:Needs review» Reviewed & tested by the community

Still good to go.

Version:8.x-dev» 7.x-dev
Status:Reviewed & tested by the community» Patch (to be ported)

Love these. Committed/pushed to 8.x.

Status:Patch (to be ported)» Needs review
StatusFileSize
new462 bytes
PASSED: [[SimpleTest]]: [MySQL] 39,679 pass(es).
[ View ]

D7 patch

Status:Needs review» Reviewed & tested by the community

Good to go.

Status:Reviewed & tested by the community» Fixed

Automatically closed -- issue fixed for 2 weeks with no activity.