I have stumbled upon an issue resulting in an infinite redirect loop when using geoip_language in conjunction with the 'Domain Access' project. After a bit of reading I came across the implementation of custom_url_rewrite_outbound and a bit later I had implemented it within geoip_language.

I thought I should share it. However I tested it for like 30 seconds only and it seemed to work so far.
I'll do a bit more testing on monday and report back, hopefully less confused than I am right now. In the meantime you guys might test it and think it's good or tell me to fuck off because I suck hairy donkeyballs.

Good evening to you dear sirs, I'm going home.

CommentFileSizeAuthor
geoip_language.module.url_alter.untested.diff2.5 KBphryk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

phryk’s picture

phryk CreditAttribution: phryk commented

Gee… Reading it now, that doesn't make any sense. What I implemented was actually *not* custom_url_rewrite but hook_url_outbound_alter() which is part of the 'url_alter'-module which is aimed at introducing a remedy to this issue.

phryk’s picture

phryk CreditAttribution: phryk commented

A bit of testing revealed that at least with my setup, everything seems to work like it ought to be.

phryk’s picture

phryk CreditAttribution: phryk commented
Status: Patch (to be ported) » Needs review
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Issue summary: View changes
Status: Needs review » Closed (outdated)