Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
http://wo0.cn/rss.xml
Notice: Trying to get property of non-object 在 taxonomy_breadcrumb_node_view() (行 70 在 /home/huoxz/public_html/sites/all/modules/taxonomy_breadcrumb/taxonomy_breadcrumb.module).
Comment | File | Size | Author |
---|---|---|---|
#14 | non-object-notice-1222922-14.patch | 1.39 KB | jantoine |
#12 | non-object-notice-1222922-12.patch | 1.23 KB | yuriy.babenko |
#2 | non-object-notice-1222922-1.patch | 761 bytes | stkrzysiak |
Comments
Comment #1
stkrzysiak CreditAttribution: stkrzysiak commentedThis appears to only happen to my nodes without any tags assigned, I am going to look into a patch.
Comment #2
stkrzysiak CreditAttribution: stkrzysiak commentedGit patch attached, it just checks to see if an object was returned, and if not, it sets $breadcrumb to an empty array.
Comment #3
Refineo CreditAttribution: Refineo commentedI have the same issue here. This module should work also if some content types are not to be assigned taxonomy at all.
I will try your patch now.
Environment
Comment #4
Refineo CreditAttribution: Refineo commentedI applied the patch above and it works fine for me now. Thank you !
Comment #5
GANYANCI CreditAttribution: GANYANCI commentedYes, it's worked.
Comment #6
mrsinguyen CreditAttribution: mrsinguyen commentedPatch in comment #2 works well. Thank you!
Comment #7
kardave CreditAttribution: kardave commentedPatch in #2 worked for me too!
Comment #8
Olarin CreditAttribution: Olarin commentedPatch works for me as well. This issue also manifests on draft content when using Workbench; obviously the patch doesn't fix the fact that the breadcrumb doesn't appear in draft mode, but at least it suppresses the unhelpful errors.
Comment #9
Refineo CreditAttribution: Refineo commentedI confirm #8 that this patch doesn't fix that breadcrumbs don't appear in Workbench draft mode.
Comment #10
Barm23 CreditAttribution: Barm23 commentedpatch code with home text
Comment #11
dgastudio CreditAttribution: dgastudio commentedsame problem, same solution
Comment #12
yuriy.babenko CreditAttribution: yuriy.babenko commentedAttaching alternate patch for the same issue.
Comment #13
Refineo CreditAttribution: Refineo commentedPatch in #12 works for me and suppresses the error messages.
Comment #14
jantoine CreditAttribution: jantoine commentedThe Taxonomy Breadcrumb module should only take over breadcrumbs if a node is in fact associated with a taxonomy/term. Otherwise it should leave the system breadcrumbs alone. The attached patch fixes this.
@Barn23
The home page breadcrumb is already added to the breadcrumb in the _taxonomy_breadcrumb_generate_breadcrumb() function. I believe you are seeing a side effect of this bug where the module is setting a blank breadcrumb to nodes that are not associated with a taxonomy/term. In this case, the updated patch will leave breadcrumbs alone and use the system breadcrumb. If you changed the home page breadcrumb text, you can change the system home page breadcrumb text to match the Taxonomy Breadcrumb module by implementing the hook_menu_breadcrumb_alter() function in either your theme (preferable) or a custom module. Example code is below::
Comment #15
Refineo CreditAttribution: Refineo commentedPatch in #14 works for me as well and suppresses the error messages.
Drupal 7.12
Comment #16
drupixPatch in #14 works for me as well.
Drupal 7.12
Comment #17
Anonymous (not verified) CreditAttribution: Anonymous commentedThis works. Nice patches everyone!
Setting this to "major" as without this patch it will certainly mess up some, perhaps all, sites using this module.
Also setting this to RTBC since we have a few reviews and it correctly maintains the intended functionality without causing any other random breakage.
Comment #18
rwilson0429 CreditAttribution: rwilson0429 commentedPatch in #14 worked great. Thanks.
Comment #19
Anonymous (not verified) CreditAttribution: Anonymous commentedHi there,
Works here, too. Please commit. It fills up logs quite severely. :)
Comment #20
jantoine CreditAttribution: jantoine commentedPatch in #14 has been committed.
Comment #22
Screenack CreditAttribution: Screenack commentedI'm running the 7.x-1.x-dev, (datestamp = "1349226018") which I presume includes the above patch and I'm still seeing this very error dialog on /taxonomy/term/1
Notice: Trying to get property of non-object in _taxonomy_breadcrumb_generate_breadcrumb() (line 92 of /var/www/drupal/sites/all/modules/taxonomy_breadcrumb/taxonomy_breadcrumb.inc).
Let me know if I should create a separate issue for this, if its not related to the original post.
Comment #23
jantoine CreditAttribution: jantoine commented@screenack,
I am unable to reproduce this issue, so it looks like you are running into a new issue, perhaps based on your setup. Please open a new issue with detailed steps on how to reproduce the issue you are seeing.
Comment #24
Screenack CreditAttribution: Screenack commentedI was able to easily create my error on a clean-and-fresh install and only tb, so I created the ticket, thanks: http://drupal.org/node/1855286
Comment #25
xurizaemonPatch applies to 6.x-1.1 and is required there also.
Comment #26
gisleThe Drupal 6 version is no longer supported. Closing this as outdated. If you think this is still relevant for Drupal 7 or Drupal 9, please open a new issue.