Based on discussion in #1188430: Rip out textgroup support from locale module, we need to postpone the commit of the update function to ensure it gets "tested" = run in a test update. However, the functionality removal is pretty important to make happen soon because lots of other work depends on it being gone. We don't want to spend time tossing around code that is going to be removed in refactorings. Read the full discussion in #1188430: Rip out textgroup support from locale module.
Postponing this one on #1182290: Add boilerplate upgrade path tests.
Parent issue
#1260628: META: Better translation management API in locale module
Comment | File | Size | Author |
---|---|---|---|
#5 | update_for_textgroup_removal-3.patch | 992 bytes | c960657 |
#4 | update_for_textgroup_removal-2.patch | 967 bytes | c960657 |
#1 | update_for_textgroup_removal.patch | 851 bytes | Gábor Hojtsy |
Comments
Comment #1
Gábor HojtsyPatch.
Comment #2
Gábor HojtsyComment #3
Gábor Hojtsy#1188430: Rip out textgroup support from locale module got committed, #1182290: Add boilerplate upgrade path tests still outstanding.
Comment #4
c960657 CreditAttribution: c960657 commentedReroll of Gabor's patch. I suspect this issue is what is causing the test bot to barf on my patch for #746240: Race condition in locale() - duplicates in {locales_source}.
Comment #5
c960657 CreditAttribution: c960657 commentedComment #7
c960657 CreditAttribution: c960657 commentedI think the test bot problem is due to #1336170: Add locale module to upgrade tests.
Comment #8
Gábor Hojtsy@c960657 you are right. I've just posted a combined patch at http://drupal.org/node/1336170#comment-5285748 to prove that it fixes the issue (apart from manually going through all the schema details and confirming it is equal to D7). I think the update itself will be committed here, I just cross-posted there for testing, so keeping this open.
Comment #9
Gábor Hojtsy#5: update_for_textgroup_removal-3.patch queued for re-testing.
Comment #10
Gábor HojtsyHa, this was committed as part of #1336170: Add locale module to upgrade tests already.
Comment #11
Gábor HojtsyTagging for base language system.
Comment #12
Gábor HojtsyAdding UI language translation tag.
Comment #13
Gábor HojtsyLanguage-base is not applicable here.
Comment #14
Gábor HojtsyTagging for config leg of D8MI.
Comment #14.0
Gábor HojtsyAdd parent