Breadcrumb inconsistency for organic groups integration

Thanks for your help. After applying the patch, seems the problem does not get solved.

However, I am not sure if the patch is applied successfully, since I got the message during patching:

Patching file node_gallery.module using Plan A...
Reversed (or previously applied) patch detected! Assume -R? [n]

Each time, I press "Y" to get it going.

Sorry if I did not apply the patch correctly.

Thanks again.

I applied the patch in #3, now the breadcrumbs for node/[nid]/sort becomes:

Home » [node_title], here [node_title] is actually the gallery name.

Is this the desired behavior of the patch?

To keep the consistency with node/[nid]/, and node/[nid]/edit, I think the breadcrumbs should be:

Home » Groups » [mygroup]

or even better:

Home » Groups » [mygroup] » [mygallery]

Thanks again, and I appreciate your help.

I am not using custom_breadcrumbs. What I did:

1) set node_gallery_gallery, and node_gallery_image to be standard group post
2) create a node_gallery_gallery node in [mygroup]

After doing this, on the view/edit tabs of the gallery node, I will have breadcrumbs like:

Home » Groups » [mygroup]

Just as for all other standard group post.

I am not sure if this answers your question.

Thanks.

This is very strange. I do not have pathauto installed.

My experience:

When I post a node within a group, and on the node view/edit page, the breadcrumbs will always be:

Home > Groups > [mygroup]

It happens to me by default. And my guess is that, on the node view/edit page of a group post, the group context will be set by og module, then the breadcrumbs will be taken care of by og module.

Do you have similar breadcrumbs as mine, for other type of group post? Say, story?

Thanks.

This is great! I have tested the patch in #11, and it works well.

@justintime, thanks very much for your effort.

I may have another request here,

Since I have set the node_gallery_image as standard group post, when I browse an image inside a gallery, which is posted in my group, the breadcrumbs look like:

Home > Groups > [mygroup]

It will be great if we can also put the gallery at the end when browsing an image:

Home > Groups > [mygroup] > [mygallery]

Also, will this great patch be ported into 6.x-3.0-beta3 ?

Thanks again!

Thanks for the great suggestion, that is exactly what I did.

Have a quick test of the patch in #13, and find following problems:

Suppose I have a group: mygroup, a gallery in this group: mygallery, and an image in this gallery: test.jpg (uploaded via plupload)

on the view tab page of this image:

Breadcrumbs: Home > Groups > [mygroup]
I expect: Home > Groups > [mygroup] > [mygallery]

On the edit tab page of this image:

Breadcrumbs: Home > Groups > [mygroup] > test.jpg
I expect: Home > Groups > [mygroup] > [mygallery]

Thanks again.

Just applied this patch, and got the same result as via #13.

For the gallery image view tab page:

Breadcrumbs: Home > Groups > [mygroup]

For the gallery image edit tab page:

Breadcrumbs: Home > Groups > [mygroup] > test.jpg

Thanks.

It is the same for a new gallery and new images inside.

My approach:
1) apply the patch on a newly downloaded NG 6.x-3.0-beta2
2) create a gallery, with og audience to be mygroup
3) upload images to that gallery via plupload, and visit the image edit page, set og audience to be mygroup (since I did not apply the og cascade patch, I need to manually change the og setting for each image )

@justintime, you see any problems here?

Thanks.

With patch in #21, I still can not have it work, even if I re-save the images or toggle the group checkboxes on the gallery.

And it is the same no matter I apply og cascading patch or not. (http://drupal.org/node/1159306#comment-4496032)

Thanks.

I think I have figured out the reason for this: the relative weights of og module and node gallery module in {system}.

After resetting the weight_of_NG > weight_of_OG, it works as desired.

My guess is that, by setting weight_of_NG > weight_of_OG, the breadcrumb handling by NG comes after the handling via OG, which leads to the desired results.

To verify this, I changed the weights: weight_of_NG < weight_of_OG, then it re-produces the problem I had before.

@justintime: could you please double check if this is the case?

If it is,

1) do we need to make sure NG has larger weight than OG in {system} ?
2) is there other ways rather than play with the weight?

Maybe we also need to document it.

Thanks a lot.

I reset weights back to zero, and tried pathauto with the settings in #24, still does not work.

The only way, so far, works for me is changing the weight.

@justintime, could you reset the weight of NG to be -1, while keep your pathauto setting, to see if you can reproduce my problem ?

Thanks.

Great! Thank you very much, and I am really sorry to drag your feet for such a long time :(

This patch works properly, and the description on the status page looks clear to me.

One little thing, In my theme, all messages in admin/reports/status page starts with an icon, except the message from NG, as shown in attachment.

Thanks.

forgot to attach the picture.

I read the description again, and feel some confusion:

Currently when I have NG weight < OG weight, I will have a message on status page, saying:

OG has a lighter weight than Node Gallery

Should we say:

OG SHOULD have a lighter weight than Node Gallery ?

Or

OG has a greater weight than Node Gallery ?

Thanks