Use proper language instead of 'und'. [#1232836]

Comment	File	Size	Author
#1	language_none-1232836-1.patch	7.43 KB	twistor

Comment #1

twistor CreditAttribution: twistor commented 28 July 2011 at 19:23

Status:

Active

» Needs review

File	Size
language_none-1232836-1.patch	7.43 KB

... and the code.

Log in or register to post comments

Comment #2

emackn CreditAttribution: emackn commented 29 December 2011 at 18:52

Status:

Needs review

» Needs work

hmm.. is LANGUAGE_NONE the right thing to use? Shouldn't we use $entity->language instead?

Log in or register to post comments

Comment #3

franz

any

Montréal

CreditAttribution: franz commented 10 April 2012 at 14:03

Priority:

Minor

» Major

I think we need to push it into major to get more attention. I'm a little ignorant of i18n implementations, but I feel we need to properly comply with it. Does $entity->language stores LANGUAGE_NONE by default as well or is it empty?

Log in or register to post comments

Comment #4

franz

any

Montréal

CreditAttribution: franz commented 10 April 2012 at 14:06

Title:

Use LANGUAGE_NONE instead of 'und'.

» Use proper language instead of 'und'.

Log in or register to post comments

Comment #5

franz

any

Montréal

CreditAttribution: franz commented 10 April 2012 at 14:24

emackn, I read a little, and it looks like $entity->language is not necessarily the field language, so it would be better to use LANGUAGE_NONE than that.

However, if we wish to implement better support, we should read it here.