Notice: Undefined index: 'base' in _color_rewrite_stylesheet()

Tagging.

Just adding link back to duplicate issue that was closed deferring to this one #789554: Notice: Undefined index: base in _color_rewrite_stylesheet() in line 437

I've run into this issue a few times before but was never sure of exactly what the cause of it was.

If this passes, I'll test this out and report back.

I'm having trouble getting color.module working in a zen based theme (with the color code ported over from Bartik, but I did add an extra color setting).

These two fixes were suggested as solutions to my problems, but neither seems to have any effect. When I change the color, the color appears in the previews of the appearance settings, but the stylesheet is apparently not being changed -- the site is still in the original color.

These are the notices and warnings I am getting:

Notice: Undefined index: type in drupal_get_css() (line 2934 of C:\wwwroot\drupal\includes\common.inc).
Warning: ksort() expects parameter 1 to be array, null given in drupal_group_css() (line 3047 of C:\wwwroot\drupal\includes\common.inc).
Notice: Undefined index: type in drupal_group_css() (line 3059 of C:\wwwroot\drupal\includes\common.inc).
Notice: Undefined variable: group_keys in drupal_group_css() (line 3079 of C:\wwwroot\drupal\includes\common.inc).
Notice: Undefined index: type in drupal_aggregate_css() (line 3119 of C:\wwwroot\drupal\includes\common.inc).
Notice: Undefined index: type in drupal_pre_render_styles() (line 3239 of C:\wwwroot\drupal\includes\common.inc).
Notice: Undefined index: base in _color_rewrite_stylesheet() (line 448 of C:\wwwroot\drupal\modules\color\color.module).

For anyone who copied color code from another theme (ie: Bartik, in my case) --

I applied this patch, and was still getting errors like "Notice: Undefined index: base in _color_rewrite_stylesheet()"
In order to fix the error, I had to add a color field in color.inc named 'base'. Bartik does not have a field named as such. Once I added this, error messages went away.

I've tested this with a variety of colorable themes using the fix provided in #1 (implemented in the patch in #6) and it solves the issue.

As #1 described, without returning $palette, if you add new colorable items to a theme they will not be displayed under the custom color scheme if the user was already using a custom color scheme.

I'm marking this RTBC because my patch simply implemented the fix in #1, I've tested this with themes that support color module and the color module itself is not very popular (from my research) and does not have a maintainer to contact for review.

Please change the issue status if you think otherwise!

This could use two things:

- an automated test so it doesn't get broken again.

- an inline comment to explain why we're adding the + $palette (the original summary in this issue would be a good base for that).

#6: include-newly-added-colorable-elements-1236098.patch queued for re-testing.
doesn't work for me. bartik used.

Doesn't work for me either.

patch doesn't work for me either, the only fix was adding "base" to the color fields replacing "bg"

$info = array(
  // Available colors and color labels used in theme.
  'fields' => array(
	'base'=> t('Background'), // labelled "background"
	'sitetitle'=> t('Site Name'),
        'sponsors' => t('Sponsor background'),
        ......

For anyone, using the color module within theme parameters to customizes colors and getting errors similar to the following after modifications:
Notice: Undefined index: base in _color_rewrite_stylesheet() (line 479)...

Patch solution #1 works for Drupal 7.X using skeletontheme.

Some reported trouble still and could appear to be the case. In order for it to take effect, it was necessary to run the update script. For good hygiene, I ran cron and cleared cache as well.

.

This function has been refactored in 8.x. This is now a 7.x only issue.

Attached screenshot of 8.x working as intended. I manually added the Fireeeee color set.

I was able to reproduce d8 not showing new *fields*. Patch attached that fixes that thanks to @markcarver

Awesome! Patch looks great :) Will need to manually test this again once it comes back green.

Issue summary still needs an update, @jlporter and I had a hard time figuring out exactly what the issue was actually about at first.

I simply reinstalled my theme and got it working.

1. I noticed the default theme garland wasn't giving me errors, but my new theme was

'

2. After I re-installed theme I set the color preset of theme to an already available option - it worked
3. And then set it to "custom" (after step #above), made changes and then saved it.

Hope this helps someone.

My issue might have been i tried to alter CSS manually, which first caused the issue.

On D7 if anyone wanted to know

Drupal 7: I was not able to get new colorable elements to work properly because of color.module: line 475 (Check if this is one of the colors in the default palette.)

The fix for this: make sure the color you have defined in the css file (the one specified in $info['css'] ) is the same color as the one in $info['schemes']['default'] (your default color profile)

6: include-newly-added-colorable-elements-1236098.patch queued for re-testing.

any progress on this? I am using the "skeleton" theme - and by now the colors seem to be "random" after saving.

#6 doesn't work for me... still get "Undefined index: base in _color_rewrite_stylesheet when updating color"

But I was able to resolve this issue by making sure I had a a base, text and link variable set for each color palette in color.inc

#9 saved me lots of time figuring out what was going on. Did my first color module implementation for a theme I developed, and started out with what I found in Bartik -> as kkuhnen pointed out, if "base" is missing in the field definitions, it throws this error.
I just renamed my background field to "base" and works like a charm.
Thanks kkuhnen!

The notice still exists in version 8.3.2. And the current solution for me is the same like mentioned in #9: using of a field with the key base and it works fine. If there is no fix available or planned, it should mentioned on the official documentation.

I've tested patch from #37 and it's looking good.

#37 works well. I've tested it, no notices anymore.

The patch in #37 is a different fix than the one in #21 and there is still no test that @catch asked for in #12 by @catch.

Debugged this and as i grok it the previous patches are only bandaids.
As @joachim noted in the dup #789554-6: Notice: Undefined index: base in _color_rewrite_stylesheet() in line 437, and here in #9, it appears in *any* theme that does not declare a 'base' key in its color configuration.

Current bartik is an instance of this, so reopened #781594: Bartik's color integration misses 'base' key.

Added a draft CR to use in patch.

Patch flying in that
* triggers deprecation errors for any theme that misses a required key
* adds a pragmatic workaround that guesses a missing base key by grepping 'bg' (which works for bartik and some other themes).

Background: Looking sharply at this code, we see that certain keys are required. (and why preceding patches are not enuff).

$base = 'base';
...
      // Not a pre-set color. Extrapolate from the base.
      else {
        $chunk = _color_shift($palette[$base], $default[$base], $chunk, $info['blend_target']);
      }
    }
    else {
      // Determine the most suitable base color for the next color.

      // 'a' declarations. Use link.
      if (preg_match('@[^a-z0-9_-](a)[^a-z0-9_-][^/{]*{[^{]+$@i', $chunk)) {
        $base = 'link';
      }
      // 'color:' styles. Use text.
      elseif (preg_match('/(?<!-)color[^{:]*:[^{#]*$/i', $chunk)) {
        $base = 'text';
      }
      // Reset back to base.
      else {
        $base = 'base';
      }

If we change the deprecation note to an error once we can, imho this is the test we need.

Ignore the last patch, this is the correct one.

This is something color module expect palette setting in your config color.theme.
.yml and schemes->default->colors in color.inc with repsect to text, link and base color schemes.

Ref: https://www.drupal.org/node/108459#stylesheets-css

I set text, link and base color schemes in color.inc and config in color.theme.
.yml and it do not show any notice.

Example:

$info = [
  // Available colors and color labels used in theme.
  'fields' => [
    'top' => t('Header background top'),
    'bottom' => t('Header background bottom'),
    'bg' => t('Main background'),
    'sidebar' => t('Sidebar background'),
    'sidebarborders' => t('Sidebar borders'),
    'footer' => t('Footer background'),
    'titleslogan' => t('Title and slogan'),
    'text' => t('Text color'),
    'link' => t('Link color'),
   'base' => t('Base color'),
  ],
  // Pre-defined color schemes.
  'schemes' => [
    'default' => [
      'title' => t('Blue Lagoon (default)'),
      'colors' => [
        'top' => '#055a8e',
        'bottom' => '#1d84c3',
        'bg' => '#ffffff',
        'sidebar' => '#f6f6f2',
        'sidebarborders' => '#f9f9f9',
        'footer' => '#292929',
        'titleslogan' => '#fffeff',
        'text' => '#3b3b3b',
        'base' => '#0071b3',
      ],
    ],

Hope if it helps but not sure if we need to fix this in code.

Need to manually test to see if this is still an issue in 8.x/9.x

Still getting the same error. @milindk can you please tell us where to find "color.theme.yml"?

As mentioned already on this thread, color module expect at least the color keys/variables/names added on the latest patches, i.e. base, lin
k, and text, so on any theme implementing it, they should be defined.

As per the new colors not being detected, the easier work-around it to remove the related configuration object, e.g. drush cdel color.theme.yourthemename.

I will keep the patch in NW status, and I would suggest to not try to guess, but instead document the needed keys, and maybe verify they are
set if the theme has color integration enabled, e.g. do not let enable the theme if that is missing.

I am also removing the Novice tag, since it changes do not feel trivial.

Finally, I have re-closed #789554-23: Notice: Undefined index: base in _color_rewrite_stylesheet() in line 437 as duplicated of this one.

Linking the duplicate.

Color has been removed from core, #3270899: Remove Color module from core.

I recreated the patch #37 to be compatible with drupal/color instead of drupal-core.