Arguments for oauth_common_form_authorization() which are declared as

function oauth_common_form_authorization($form_state, $token) {

should be declared as

function oauth_common_form_authorization($form, &$form_state, $token) {
CommentFileSizeAuthor
#2 oauth.auth-forms.2.patch2.58 KBsun
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nevets’s picture

nevets CreditAttribution: nevets commented

In addition, the code expects $user so the function should probably be declared as

function oauth_common_form_authorization($form, &$form_state, $user, $token) {

and the menu item updated to pass $user.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Priority: Major » Normal
Status: Active » Needs review
FileSize
oauth.auth-forms.2.patch2.58 KB

In D7 all form constructors take $form and &$form_state as the first arguments.

Attached patch fixes those authorization forms.

jobeirne’s picture

jobeirne CreditAttribution: jobeirne commented
Status: Needs review » Closed (fixed)

Nevets, thanks much for the work. Sun, thank you for the patch. It wouldn't apply cleanly to HEAD, so I investigated, re-rolled it myself, and committed. I've done a second commit containing your cancel link fix and I've attributed it to you.