Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I've noticed a few minor things that could do with cleaning up in the module's code:
- the code files need a @file docblock
- some functions, eg mail_logger_load(), theme_mail_logger_read_mail() are missing docblocks
- mail_logger_form_overview_submit() is incorrectly described as a hook_submit -- it's a form submission handler ;)
- missing space either side of some dot operators.
- probably other stuff if we were to run this through Coder ;)
Not much point submitting a patch when I've just filed so many others; I'll come back to this once those are in :)
Comments
Comment #1
fizk CreditAttribution: fizk commentedjoachim, Looking forward to it :)
Comment #2
fizk CreditAttribution: fizk commentedComment #3
NancyDruI'd appreciate a 7.x patch as well.
Comment #5
NancyDruI have done a Coder review on 7.x and committed the changes.
Comment #6
NancyDru