I've noticed a few minor things that could do with cleaning up in the module's code:

- the code files need a @file docblock
- some functions, eg mail_logger_load(), theme_mail_logger_read_mail() are missing docblocks
- mail_logger_form_overview_submit() is incorrectly described as a hook_submit -- it's a form submission handler ;)
- missing space either side of some dot operators.
- probably other stuff if we were to run this through Coder ;)

Not much point submitting a patch when I've just filed so many others; I'll come back to this once those are in :)

Comments

fizk’s picture

Issue summary: View changes

joachim, Looking forward to it :)

fizk’s picture

Status: Active » Postponed (maintainer needs more info)
NancyDru’s picture

I'd appreciate a 7.x patch as well.

  • NancyDru committed db7e042 on 7.x-1.x
    Issue #1239534 by NancyDru - Coder clean up.
    
NancyDru’s picture

I have done a Coder review on 7.x and committed the changes.

NancyDru’s picture

Status: Postponed (maintainer needs more info) » Closed (outdated)