hook_admin_paths() doesn't work with path aliases

So is the issue that hook_admin_paths() doesn't work with path aliases?

I think it may have only been designed to work with system paths, but (a) the documentation is unclear, (b) it sounds from the description above like it "almost" works (overlay starts to open and then closes again), and (c) it would definitely be useful to do what's described above (have the admin path status depend on the node type) and I don't think there's any reasonable way to achieve that without using path aliases.

Hm, I just tried 'node/*' => TRUE in hook_admin_paths_alter() and it worked fine for me.

Maybe you should post an example of the exact code you're using?

Hm, I still can't reproduce that problem. I just tried creating a custom module, pasting the above code into it, and turning on the module. For node/* paths, everything worked as the code said it should - they all appeared inside the overlay for me.

Any chance you have some other module installed which is implementing hook_admin_paths_alter() and overriding this?

Perhaps the problem comes from disabling other admin paths?

I don't think it should. But it looks to me like the code you have for doing that disabling is unnecessary (since at the end you completely rewrite the $paths variable with a new value anyway).

I know this is an old issue but your code snippet has a problem in that you are setting all the existing values to false for no reason as then you replace the whole existing array with your new array.

You could get rid of your foreach loop.

Also, if your module doesn't run last other modules could add more overlay paths after you get rid of them all.

I'm getting this problem in a similar way. Say we have 2 content types tasks and projects. We use pathauto to set the alias to 'projects/[node:title]' and 'tasks/[node:title]'.

We want to show projects in the default theme, but show tasks in the overlay. So we implement hook_admin_paths_alter.

function mymodule_admin_paths_alter(&$paths){
  $paths['tasks/*'] = TRUE;
}

This causes the overlay to start to render (url shows: "/...#overlay=tasks/taskname"), but then it redirects to the actual node (url shows: "/tasks/taskname").

However, if we change our hook implementation:

function mymodule_admin_paths_alter(&$paths){
  $paths['tasks/*'] = TRUE;
  $paths['node/*'] = TRUE;
}

This causes the desired result. The task node is rendered in the overlay. But then if we go over and take a look at a project node, the node is not rendered in the overlay, but instead is rendered in the administrative theme. So i thought lets do something like this:

function mymodule_admin_paths_alter(&$paths){
  $paths['tasks/*'] = TRUE;
  $paths['node/*'] = TRUE;
  $paths['projects/*'] = FALSE;
}

But this doesnt do anything.

So i traced to problem back and it seems to be a problem in path_is_admin($path). The $path when viewing a node is always "node/*".

Attached is a patch which check the path for an alias then proceeds to set that path as admin.

This patch applies cleanly to D7 current stable as well. Solved my problem.

The patch in #8 works for me. Thanks!

I am using D7.14 and it doesn't apply for me:

git apply admin-path-alias-124074-8-d8.patch
admin-path-alias-124074-8-d8.patch:14: trailing whitespace.
$path_map['non_admin'][$path] = drupal_match_path($alias, $patterns['non_admin']);
error: core/includes/path.inc: No such file or directory

doens't apply because of /a/core

but with patch it does:
patch -p1 < *patch
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/core/includes/path.inc b/core/includes/path.inc
|index 223ab04..6bca12b 100644
|--- a/core/includes/path.inc
|+++ b/core/includes/path.inc
--------------------------
File to patch: ./includes/path.inc
patching file ./includes/path.inc

The patch was for D8. You should be able to just remove the /core and it should be good for D7.

+++ b/core/includes/path.incundefined
@@ -499,6 +499,13 @@ function path_is_admin($path) {
+    $path_map['non_admin'][$path] = drupal_match_path($alias, $patterns['non_admin']);	

There's whitespace at the end.

Also, I think you can move this code into the if statement. Than you can drop the second call to path_get_admin_paths() as well.

This patch fixes the whitespace and another small coding style. As for moving the code into the if statement, which if statement? the one i introduced, or the previous one?

I confirm, that this works well for me in D7. Do you think, that it can be commited?

The number of followers can influence the priority? Would like to see a back-port for D7 too!

Overlay doesn't exist in D8.

Better title.

Patch still applies to Drupal 8 - doesn't even need a reroll, amazingly :)

Oops.

Note: #1316692: Convert hook_admin_paths() into declarative properties on routes would fix this bug automatically as paths are not longer important.

I can't see /core/includes/path.inc

hook_admin_paths() doesn't exist in Drupal 8/9.