Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Attached is a patch that allows the administrator to change the help text to be displayed for the magnifier icon.
Comment | File | Size | Author |
---|---|---|---|
#1 | gallery-formatter-full-image-text-input-test-passed.png | 35.46 KB | DRIVE |
galleryformatter-magnifier_icon_text.patch | 2.42 KB | Boobaa |
Comments
Comment #1
DRIVE CreditAttribution: DRIVE commentedTested your patch and it works just fine.
Just 2 things of note:
1) Probably should use Dev branch as a few things have changed that I am fairly certain Manuel will keep there.... and pretty much all new "enhancements" should be using development version as the proper place for all tests. I believe you can safely use the dev version in Production as all the current stuff in there is stable in my view. I am using it in 4 or 5 production sites.
2)
From #1 above, the code for alt and title has changed (which I believe will be kept as in Dev version)
Also, we don't want to change the image title due to empty full_image_text so I would leave that part out.
p.s. if you re-roll using dev version change version when you post back. Keep status as-is... ... best until "officially" approved.
I'll let you re-roll the patch since you put the time and effort in. I used your patch in the dev version (7.x-1.x-dev), minus my noted items, and works just fine. Great for the multi-lingual compatibility! Good eye. NIce job!
Attached image shows input, screen cap taken after updating, saving and testing. Works as expected.
Comment #2
Manuel Garcia CreditAttribution: Manuel Garcia commentedThanks for the patch!
Yes, patches have to be built against dev, in any project on drupal.org.
I'm not sure this is something that many people would need, and it adds more options to the formatter which always is a bad idea in terms of usability. So I'm not sure we should add this functionality.
Comment #3
DRIVE CreditAttribution: DRIVE commentedI think it is good for multi=lingual.... but, it is so easy to just replace those values it might not be worth clogging it up.... particularly since the arrows (all 4) need the same treatment in order to unify the feature.... not a "bad" idea though, especially for those who get go0gly eyed when viewing or having to modify any code.....