Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The views pane plugin doesn't check if the views header/footer "Display even if view has no result" is checked and return nothing because of this.
Comment | File | Size | Author |
---|---|---|---|
#4 | ctools-1245202-4.patch | 652 bytes | OnkelTem |
#1 | 1245202-display-even-if-no-results-views-panes.inc_.patch | 1.19 KB | jsacksick |
Comments
Comment #1
jsacksick CreditAttribution: jsacksick commentedCheck every header/footer item and see if "Display even if view has no result" is checked before returning nothing in
views_pane.inc
.Comment #2
jsacksick CreditAttribution: jsacksick commentedComment #3
jsacksick CreditAttribution: jsacksick commentedDuplicate, see #1217394: Change notice: "Display even if view has no result" not working
Comment #4
OnkelTem CreditAttribution: OnkelTem commentedOk, this is the patch.
NOTE: It requires applying another patch against Views: #1217394: Change notice: "Display even if view has no result" not working see #93
Comment #5
OnkelTem CreditAttribution: OnkelTem commentedFor some reason I can't even view the patch from #4 - getting "504 - Gateway Timeout" error. SO this is the patch, it is one-liner:
Comment #7
frankcarey CreditAttribution: frankcarey commentedFWIW, IT seemed the issue in the current release was that the view style plugins are almost all set to not be used. There is property they can use called 'even empty' which will make sure the style plugin still renders. (you can see it referenced in the patch above). I got this working with the current views release by altering the plugins that I needed like so.. not sure why this isn't (1) a views option, and (2) set on by default. Without it, my hook_preprocess_views_view_list() didn't get called because the plugin doesn't get called apparently. This also resulted in the header and footers working as well.
Comment #8
milos.kroulik CreditAttribution: milos.kroulik commentedPatch from #4 seems to be working fine when used together with the mentioned patch.
Comment #9
MustangGB CreditAttribution: MustangGB commentedGreat patch.
Comment #10
MustangGB CreditAttribution: MustangGB commentedComment #11
DamienMcKennaThis wasn't added to 7.x-1.10, bumping it to 7.x-1.11.
Comment #12
DamienMcKennaComment #13
rivimeyPatch applies cleanly on current 7.x-1.x git.
At this point, the required Views patch mentioned in #4 is in state 'needs review'. However, it seems quite possible that it could be marked RTBC at this point.
It has been added by @MustangGB to #2505379
Jakob and I agreed that we cannot proceed with this in ctools because the views patch hasn't reached consensus quite yet.
Comment #14
MustangGB CreditAttribution: MustangGB commented@rivimey: Seems like you're saying we should postpone on #1217394: Change notice: "Display even if view has no result" not working.
Comment #15
rivimeyMustangGB, I am no issue queue expert, but given this patch cannot work without the views patch, and the views patch is still being discussed (at least, that's the way it appears to me), this patch cannot be applied
I'd say 'depends on' rather than 'postponed' but perhaps they're equivalent here.
Comment #16
DamienMcKennaThis wasn't added to 1.11.
Comment #17
Tubia87 CreditAttribution: Tubia87 commentedHi,
I've tested the patch #4 with latest ctools release, 1.12, and it doesn't apply. However I was able to apply the one referred here and it works.
So, actually, the problem seems to be fixed with 1.12. Other feedbacks?
Comment #18
rivimeyTubia87, thanks for your input. We would indeed appreciate other experience with 'unpatched' ctools 1.12 and views 7.x-3.14 + views-1217394-108.patch