On isbn2node.module there is empty spaces before the <?php which invalidates RSS feeds. Removing this empty space restores RSS functionality.

Also, I have been using ISBN2Node to help feature books on my library site, thank you very much for this and I hope you continue to develop it. I could not find a donate button but I definitely appreciate this program. Thank you.

CommentFileSizeAuthor
#3 isbn2node-whitespace-1248604-3.patch195 bytesbtopro
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vertikal.dk’s picture

vertikal.dk CreditAttribution: vertikal.dk commented

gvenegas84,

Glad you like the module, and very sorry that I "forgot" a coumple of spaces in there!

I'll hunt them down, remove them and update the module.

I'm surprised I didn't find them since I usually test my modules quite thoroughly and run them through the coder module, which usually finds such errors.
A quick fix is to open the isbn2node.module, which has two leading spaces before the first <?php. Simply delete them.

Martin

vertikal.dk’s picture

vertikal.dk CreditAttribution: vertikal.dk commented
Assigned: Unassigned » vertikal.dk
Priority: Normal » Major
btopro’s picture

btopro CreditAttribution: btopro commented
Status: Active » Needs review
FileSize
isbn2node-whitespace-1248604-3.patch195 bytes

patch to fix this so it can be included in distro packaging at the very least.

vinmassaro’s picture

vinmassaro CreditAttribution: vinmassaro commented
Status: Needs review » Reviewed & tested by the community

This works, thanks.

glass.dimly’s picture

glass.dimly CreditAttribution: glass.dimly commented
Issue summary: View changes

Wow. I can't believe this code has not been committed.

There goes a couple hours of my life tracking down an RSS feed that wouln't validate because of these four spaces.

Here's the error I was getting for those that walk down this road later:

XML parsing error: <unknown>:1:4: XML or text declaration not at start of entity

vertikal.dk’s picture

vertikal.dk CreditAttribution: vertikal.dk as a volunteer commented

glass.dimly,

I'm sorry for having wasted a couple of hours of your time due to a dumb error from my hand. I will commit a version with the edit ASAP and hopefully save others the same trouble, but as it says in the description of this module (and all my other modules):

"Due to health problems (severe unfortunately - MS) I can't maintain my modules as keenly as I want to, and will in periods not be actively following up on issues. I will take my stints, but there will be pauses. I apologize for the inconvenience this causes."

Martin