Follow-up from #907690-87: Breadcrumbs don't work for dynamic paths & local tasks #2
Problem/Motivation
The changes made to the _menu_translate()
function by #907690-67 (Commit diff) included adding two new variables: $tab_root_map
and $tab_parent_map
. These variables are defined inside an if
statement, but unconditionally referenced later. This clutters the watchdog table with two Undefined variable warnings for every page load.
Proposed resolution
The variables should be unconditionally defined.
Remaining tasks
This proposed patch needs to be reviewed and committed.
User interface changes
None.
API changes
None.
Comment | File | Size | Author |
---|---|---|---|
#1 | _menu_translate-undefined-variables-1249794-1.patch | 1.09 KB | pillarsdotnet |
Comments
Comment #1
pillarsdotnet CreditAttribution: pillarsdotnet commentedPatch.
Comment #2
sunHow comes that I don't see any notices? (yes, my error_reporting is ultramax.)
Comment #3
kscheirer#1: _menu_translate-undefined-variables-1249794-1.patch queued for re-testing.
Comment #5
mdupontDuplicate of #951098: tab_root_map and tab_parent_map notices undefined in _menu_translate()