Follow-up from #907690-87: Breadcrumbs don't work for dynamic paths & local tasks #2

Problem/Motivation

The changes made to the _menu_translate() function by #907690-67 (Commit diff) included adding two new variables: $tab_root_map and $tab_parent_map. These variables are defined inside an if statement, but unconditionally referenced later. This clutters the watchdog table with two Undefined variable warnings for every page load.

Proposed resolution

The variables should be unconditionally defined.

Remaining tasks

This proposed patch needs to be reviewed and committed.

User interface changes

None.

API changes

None.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pillarsdotnet’s picture

Status: Active » Needs review
Issue tags: +Needs backport to D7
FileSize
1.09 KB

Patch.

sun’s picture

Issue tags: +Needs tests

How comes that I don't see any notices? (yes, my error_reporting is ultramax.)

kscheirer’s picture

Status: Needs review » Needs work
Issue tags: +Needs tests, +Needs backport to D7

The last submitted patch, _menu_translate-undefined-variables-1249794-1.patch, failed testing.

mdupont’s picture

Status: Needs work » Closed (duplicate)