When visiting admin/config/system/cron the text reads "Cron takes care of running periodical tasks like checking for updates and indexing content for search." It should read "Cron takes care of running periodic tasks like checking for updates and indexing content for search."

Files: 
CommentFileSizeAuthor
#30 misnomer-and-spacing-1251768-30.patch693 bytesvegantriathlete
PASSED: [[SimpleTest]]: [MySQL] 36,449 pass(es).
[ View ]
#29 D7-misnomer-and-spacing-1251768-29.patch693 bytesvegantriathlete
PASSED: [[SimpleTest]]: [MySQL] 36,478 pass(es).
[ View ]
#23 misnomer-and-spacing-1252768-23.patch692 bytesvegantriathlete
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch misnomer-and-spacing-1252768-23.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.
[ View ]
#22 1252768-22.patch691 bytesultimateboy
PASSED: [[SimpleTest]]: [MySQL] 33,269 pass(es).
[ View ]
#20 1252768-7.txt691 bytesultimateboy
#17 d7-1252768-8.patch693 bytesrfay
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch d7-1252768-8_0.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.
[ View ]
#8 d7-1252768-8.patch693 bytesultimateboy
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch d7-1252768-8.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.
[ View ]
#7 1252768-7.patch691 bytesultimateboy
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1252768-7.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.
[ View ]
#2 change-periodical-to-periodic-1252768-2.patch689 bytesvegantriathlete
PASSED: [[SimpleTest]]: [MySQL] 33,090 pass(es).
[ View ]
#1 correct-periodical-misnomer-1252768-1.patch689 bytesvegantriathlete
PASSED: [[SimpleTest]]: [MySQL] 35,757 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new689 bytes
PASSED: [[SimpleTest]]: [MySQL] 35,757 pass(es).
[ View ]

Do you still do MTPOM? Enjoy!

Version:7.7» 8.x-dev
StatusFileSize
new689 bytes
PASSED: [[SimpleTest]]: [MySQL] 33,090 pass(es).
[ View ]

I guess patching D7 is a bigger issue than I thought, since it would require changing translations. Here is the patch rolled against D8. Do I get to be a core contributor for D8?

Status:Needs review» Reviewed & tested by the community

Simple change for D8 to make this sentence grammatically correct. I would actually argue that backporting this to D7 does not break translations because I would hope that translators did not interpret this literally... and if they did, well, they should fix it too. But regardless, setting to rtbc for D8.

Version:8.x-dev» 7.x-dev
Issue tags:+needs backport to D7

Committed to 8.x.

This will break translations in the sense that the string change makes any translation outdated. However how frozen string freeze really is is under discussion in http://groups.drupal.org/node/154304

I'm not clear what the outcome of that is so moving back to 7.x for webchick to consider.

The backport already exists above.

Version:7.x-dev» 8.x-dev
Category:task» bug
Status:Reviewed & tested by the community» Needs work

The concatenation was off in the patch that was committed. Could that please be fixed? (there should be a space on either side of the . characters)

This is an actual bug fix in the string, so I think we could commit it to D7.

Status:Needs work» Needs review
StatusFileSize
new691 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1252768-7.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.
[ View ]

Sorry I missed that in the review. Here's a patch to fix the issue in D8. New patch coming for D7.

StatusFileSize
new693 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch d7-1252768-8.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.
[ View ]

And here's the patch for D7.

Status:Needs review» Reviewed & tested by the community

Both #7 and #8 look good to me.

Status:Reviewed & tested by the community» Needs work

rfay suggested changing status to retry testing.

Status:Needs work» Needs review

One more time?

Status:Needs review» Reviewed & tested by the community

Re-queued, back to RTBC.

Status:Reviewed & tested by the community» Needs work

Seems I broke the test system. Once more around the block.

Status:Needs work» Needs review

Back to NR.

Status:Needs review» Needs work

Sorry for the pain.

Status:Needs work» Needs review

StatusFileSize
new693 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch d7-1252768-8_0.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.
[ View ]

Trying again by re-uploading. Sorry

Status:Needs review» Needs work
Issue tags:-needs backport to D7

The last submitted patch, d7-1252768-8.patch, failed testing.

Issue tags:+needs backport to D7

The last submitted patch, d7-1252768-8.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new691 bytes

Let's try re-uploading the D8 patch :)

Status:Needs review» Reviewed & tested by the community

I never thought a patch that added a few spaces could be so difficult. These are ready to go, testbot is just having hiccups. Comment #7 is for Drupal 8, and Comment #8 is for D7.

StatusFileSize
new691 bytes
PASSED: [[SimpleTest]]: [MySQL] 33,269 pass(es).
[ View ]

Just because I really want to see this turn green. This is for D8 once more.

StatusFileSize
new692 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch misnomer-and-spacing-1252768-23.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.
[ View ]

And here it is again for D7.

Status:Reviewed & tested by the community» Needs work

The last submitted patch, misnomer-and-spacing-1252768-23.patch, failed testing.

Version:8.x-dev» 7.x-dev
Status:Needs work» Reviewed & tested by the community

That test failure's ok, and to be expected. Unfortunately, testbot only knows to test one branch at a time, and the issue's currently on "8.x-dev" so the 7.x one will fail.

However, #22 was exactly what I'm looking for, thanks! Committed and pushed to 8.x.

Now let's try and move this back to 7.x and see what it thinks about #23.

Issue tags:-needs backport to D7

Status:Reviewed & tested by the community» Needs work
Issue tags:+needs backport to D7

The last submitted patch, misnomer-and-spacing-1252768-23.patch, failed testing.

I'm rolling it again right now. Hold on.

StatusFileSize
new693 bytes
PASSED: [[SimpleTest]]: [MySQL] 36,478 pass(es).
[ View ]

This is getting ridiculous ;-)

Here it is again for D7 starting from the beginning. Let's hope it doesn't choke on the line endings.

StatusFileSize
new693 bytes
PASSED: [[SimpleTest]]: [MySQL] 36,449 pass(es).
[ View ]

Okay, I guess I triggered the ignore by placing the D7 in front. Let's try it renamed.

Status:Needs work» Reviewed & tested by the community

Heh, one other quirk of the testbot is that things need to be either "needs review" or "reviewed & tested by the community" for it to test them.

(Oh, the things you forget are utterly confusing until you need to explain them out loud. :D)

We'll still have to see what happens with EOLs (I'm doing this on Windows -- Don't have my Ubuntu machine fully set up, yet). When I set notepad++ to use Unix EOL's I get a warning from Git Bash about LF being changed to CRLF when I create the diff. So, I still may need to pull the patch back into notepad++ to convert the EOL's to Unix again.

Ah, yes. I remember that pain very well. :(

Good luck, my friend! May testbot bless your patches. :)

@webchick: Once it passes, could you do me the favor of using --author="vegantriathlete <vegantriathlete@491720.no-reply.drupal.org>" on the commit. I'm desperate to actually have the commit show up under my Commits tab on my profile :-)

Okay, I'm going to meditate for one hour and I'll check back on this crazy testbot.

Success! Let me know if you still need me to convert the EOLs.

Status:Reviewed & tested by the community» Fixed

Awesome! :D

Committed and pushed to 7.x. Thanks.

And unfortunately, I'm not comfortable using Git's --author flag on core commits, because apart from more minor issues like this, there is almost no patch committed to core that's not a result of multiple peoples' work. It would be unfair to credit *one* person with 'first class' commit credit, at the expense of all the other people who also worked on an improvement.

There are folks working on improving this situation in the future; for example, moving to a model where each issue in the issue queue is a repository that anyone can commit to and maintainers would just merge the changes in, or using the Git 'notes' field as a means of adding additional credit to others.

But for now, I have to stick with the old crappy and legacy comma-separated names way, out of fairness. :)

I understand your point about the credit. Even with this simple patch, ultimateboy helped out with your request for the proper spacing around the concatenation symbol.

Automatically closed -- issue fixed for 2 weeks with no activity.