The form action URL is not escaped properly, generating badly-formed XML (as can be tested by installing http://drupal.org/project/xhtml).

See patch.

CommentFileSizeAuthor
plus1-xhtml.patch1.18 KBohnobinki
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

NancyDru’s picture

NancyDru
she/her/hers
Primary language English
Location Boston
CreditAttribution: NancyDru commented
Status: Active » Postponed (maintainer needs more info)

You wouldn't be looking for someone to encourage use of your module, would you? No one has ever complained before.

ohnobinki’s picture

ohnobinki CreditAttribution: ohnobinki commented
Status: Postponed (maintainer needs more info) » Needs review

I am noting that the Plus 1 module produces invalid HTML. It is easier to notice errors such as this when asking the web browser to parse the document as XML.

Thus this bug is valid regardless of how you validate the HTML on your site. I am just referencing the module as a way to expose the error (on mozilla browsers, for example, sending a document with invalid XML as application/xhtml+xml produces a big error message). I do not recommend the module be used for production sites because drupal does not produce well-formed output, but I find it useful for developing and getting it closer to the ideal...