API page: http://api.drupal.org/api/drupal/modules--system--system.api.php/functio...

Describe the problem you have found:

No function body on hook_file_insert() doc... Needs one!

Files: 
CommentFileSizeAuthor
#6 adding_hook_file_insert_example-1260162-6.patch906 bytesBès
PASSED: [[SimpleTest]]: [MySQL] 32,919 pass(es).
[ View ]
#2 adding_hook_file_insert_example-1260162-2.patch1.15 KBmichaellenahan
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in modules/system/system.api.php.
[ View ]

Comments

Assigned:Unassigned» michaellenahan

i'm at drupalcon london doc sprint. working on this with kay_v.

StatusFileSize
new1.15 KB
FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in modules/system/system.api.php.
[ View ]

Hello from DrupalCon in sunny South London.
We're at the doc sprint and have added an example.
Thanks to: bes and kay_v

Status:Active» Needs review

Status:Needs review» Needs work

The last submitted patch, adding_hook_file_insert_example-1260162-2.patch, failed testing.

Seems to have too many parens in this line:

+  if (empty($validate))) {

Also, this bit at the end of the patch needs to be removed:

diff --git a/scripts/drupal.sh b/scripts/drupal.sh
old mode 100755
new mode 100644
diff --git a/scripts/password-hash.sh b/scripts/password-hash.sh
old mode 100755
new mode 100644
diff --git a/scripts/run-tests.sh b/scripts/run-tests.sh
old mode 100755
new mode 100644

Status:Needs work» Needs review
StatusFileSize
new906 bytes
PASSED: [[SimpleTest]]: [MySQL] 32,919 pass(es).
[ View ]

new patch with the fix

Status:Needs review» Reviewed & tested by the community

Looks good, thanks for the follow-up! Should go into d7/d8 I think.

Status:Reviewed & tested by the community» Fixed

Committed to 7.x and 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.