External Links on admin navigation [#1261042]

The check access patch that was implemented in June of last year disabled external links from being added to the admin navigation. - http://drupal.org/node/815492

Proposed solution:
template.php

starting on line 87:

    foreach ($menu_tree as $key => $item) {
      $router_item = menu_get_item($item['href']);
      $checkexternal = strpos($item['href'],'http');
      if (!$router_item['access'] && $checkexternal === FALSE) {
        continue;
      }

Comments

Comment #1

sign CreditAttribution: sign commented 8 December 2011 at 17:06

Status:

Needs review

» Fixed

Thanks for your report and patch.
I have fixed it in dev, in Drupal API we have a function that checks whether the link is external or not and counts with other protocols as well. http://api.drupal.org/api/drupal/includes--menu.inc/function/menu_path_i...

So the final code looks like:

    foreach ($menu_tree as $key => $item) {
      $router_item = menu_get_item($item['href']);
      if (!$router_item['access'] && !menu_path_is_external($item['href'])) {
        continue;
      }

Although it does display all the external links including the ones that are pointing to some specific admin page (eg. http://localhost/admin/build/block) but I guess that is up to the administrator who is maintaining the menu, etc... not going to add another check whether it is an internal link with the full URL or not.

Thanks