States API disabled state handler filters out nonexistent class "form-element" and doesn't disable certain form element types

hi, is this open or closed?

This patch solves only a patch of trouble, the disabled element is DIV but disabled attribute affects only inputs

Patch includes #1 and also extends disbled attribute to all (select, input, textarea) inside disabled element

This changes behaviuor to actially disable all sub-inputs of element but currently it just colorize inputs with patch #1, default behaviour is broken

Re-roll for D8

Could you please provide some tips on what is the problem and how patch solves it? I would like to review the patch, but don't know how to compare behavior before and after the patch

Currently the states system has ability to disable elements but actually no disable is happens (just a visual styling)
My patch tries to change his to actual disable of elements

Since I don't see any viable way to make this part of any test, and patch looks fine, RTBC

Committed and pushed to 8.x. Thanks!

Marking for backport.

Re-roll for D7

Same as in 8.x

Committed and pushed to 7.x as well. Thanks!

if the form #type is set to "hidden" then it is not disabling. I tested changing the #type to textfield and it worked fine.

@Mac_Weber, what do you mean exactly - are you saying this patch introduced a regression?

(I'm not sure the use case for client-side disabling of a hidden element, but maybe there's something I'm not thinking of.)

In any case, this fix looks a bit broader than the original issue title, so I'm changing that and also mentioning this in CHANGELOG.txt and the release notes.

@David_Rothstein the behavior before this patch is the same as after patching, regarding disabling hidden elements.

I have right now a use case I managed using custom JS to disable this element, yet it would be nice to use the Drupal API to do it. My use case: I have a checkbox which gives the use a option to send some facetapi filters or just make a whole new search. These filters in my use case are sent using hidden input, which I need to disable in order to clear them if the checkbox is unset.

Hm, interesting, thanks.

Since it doesn't seem directly related to the patch that was already committed in this issue, I think it would make more sense for you to create a new issue (feature request) for that functionality. That way it can start fresh as a separate issue. Of course feel free to post a link to it here, though.

I opened a new issue #1834450: States API disabled state handler doesn't disable hidden input elements