Patch with several bugfixes

Holy damn... AWESOME, man.
Too bad this isn't for Drupal 7...

"y" missing

I would love to be able to use this. Any chance we can get these fixes into the main module sooner rather than later?

I'd try installing the patch myself but I don't think I am able to run the "patch" command in Windows and I don't have Shell access. If anyone can walk me through how to do it on Windows, then I will give it a go!

Facing same problem even with D7 version of ajax comments. Someone please commit the patch.

I applied your patch (on drupal 6.22), started working a preview, but sending comments on the Save button has broken: there is ajax-loader.gif that's all. Firebug write: "uncaught exception: Syntax error, unrecognized expression: #" The error happens on themes with <div class="comment... in comment.tpl.php

Great job, many thanks for these patches! Just one bug report i found yesterday:

Drupal.ajax_comments_reply_click = function() {
  // We should only handle non pressed links.
  if (!$(this).is('.pressed')){
    action = $(this).attr('href');
    form_action = $('#comment-form').attr('action');
    link_cid = ajax_comments_get_cid_from_href(action);
    rows = Drupal.settings.ajax_comments_rows_default;
    
    if ($('#comment-form-content').attr('cid') != link_cid) {
    	<strong>ajax_comments_remove_editors();</strong>

If you delete the line marked bold above the mod don't work in FireFox (tested in 8.0) and in IE 9.0. All looks like you haven't use this mod at all. In Google Chome it works!

In other case (line 181):

   // We don't need to load everything twice.
    if (!$(this).is('.last-clicked')) {
   	      // We should remove any WYSIWYG before moving controls.
 	      <strong>//ajax_comments_remove_editors(); </strong>

Thanks for your work on this patch, its going to be helpful for me on a site i'm working on where I wasn't quite happy with the ajax comments.

However, when applying this patch, and having comments set to be shown oldest first, the new comment isn't inserted correctly and the form freezes.

The problem is in ajax_comments_insert_new_comment() function, new_id is never set because the .comment div has no id attribute.

This change worked for me, changing this:

    var new_id = $(".comment",$comment).attr('id');

to:

    var new_id = 'ajax-comment-new';
    $(".comment", $comment).attr('id', new_id);

Edit: If you take this approach, you also need to make sure the id attribute is removed after the comment has been inserted using something like this: $(".comment", $comment).removeAttr('id');

It may help these fixes be added to the module if they were split into smaller ones, a combined patch makes it quite a task to check everything.

Hi Smoothify, I had the same problem you did. Where (what line) did insert that last line you mention?

$(".comment", $comment).removeAttr('id');

My js sucks so I'm just trying to patch this up the best I can.

@pribeh

sorry, i can't tell you exactly which line as i have other modifications. However the entire insert_new_comment function should be like this:

/**
 * Find a place for a new comment.
 */
function ajax_comments_insert_new_comment($comment) {
  if ($('#comment-form-content').attr('cid') == 'edit') {
    $('#comment-form-content').before($comment);
    $('.editing').remove();
    $('#comment-form-content').attr('cid', 0);
  }
  else if (($('#comment-form-content').attr('cid') <= 0) || !Drupal.settings.ajax_comments_nested) { // insert as last
    var new_id = 'ajax-comment-new';
    $(".comment", $comment).attr('id', new_id);
    var $where;

    if (!Drupal.settings.ajax_comments_oldest_first) {
      $where = $('#comments .comment:not(#'+new_id+',.preview-item, #post-):first').before($comment);
      if ($where.length == 0) {
        $where = $('#comments > :last').after($comment)
      }
    }
    else {
      $where = $('#comments .comment:not(#'+new_id+',.preview-item, #post-):last');
      if ($where.length == 0) {
        $where = $('#comment-preview');
        $where.before($comment);
      }
      else {
       $where.after($comment);
      }
    }
    $(".comment", $comment).removeAttr('id');
  }
  else { // reply as a nested comment
    if (Drupal.settings.ajax_comments_oldest_first && $('#comment-form-content').next().is('.indented')) {
      $('#comment-form-content').next().append($comment);
    }
    else {
      $('#comment-form-content').before($comment);
      $comment.wrap('<div class="indented"></div>');
    }
  }
}

hope that helps

@smoothify, works great! Thanks a bunch.

important in bold

Issue is closed because 6.x version is unsupported. Feel free to open new issue for 7.x or 8.x versions of module.