Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This issue is part of meta issue #1931088: [META] Fixing tests
I created a patch to add South Sudan, "ss", into the location.inc file. I have attached the patch. It seems to work - South Sudan appears in the country drop down and content can be created with that location and saved with no problems.
I would appreciate it if someone could just check it and let me know if I've missed anything - this is my first patch btw!
Thanks
Comment | File | Size | Author |
---|---|---|---|
#12 | south_sudan-1271066-12.patch | 2.59 KB | tomogden |
#9 | south_sudan-1271066-9.patch | 802.65 KB | tomogden |
#3 | location.ss_.inc_.zip | 496 bytes | Sinovchi |
#3 | location.sd_.inc_.zip | 540 bytes | Sinovchi |
southsudan.patch | 476 bytes | ecoluke | |
Comments
Comment #1
esKq CreditAttribution: esKq commentedSubscribe
Comment #2
Sinovchi CreditAttribution: Sinovchi commentedThis patch is working for me too. I'm here including location.ss.inc file for South Sudan.
Comment #3
Sinovchi CreditAttribution: Sinovchi commentedThe attachments: for Sudan and South Sudan
Comment #4
tomogden CreditAttribution: tomogden commentedI have installed this fix in my D7 3.x version, and I believe these files should be committed ASAP on all versions, but for D7 3.x it does not change the country list in Drupal core. You will need something like the Countries module for that.
Comment #5
tomogden CreditAttribution: tomogden commentedSouth Sudan is recognized worldwide as a country. This needs to be fixed!
Comment #6
podarokpostponed before tests fix
#1931088: [META] Fixing tests
Comment #7
podaroktests fixed #1931088: [META] Fixing tests
lets go
Comment #9
tomogden CreditAttribution: tomogden commentedHere is a patch rolled from the files offered in #3, which should test better than the first exploratory patch. But if not, then we will have a known test result to work with for fixing.
Comment #10
tomogden CreditAttribution: tomogden commentedComment #12
tomogden CreditAttribution: tomogden commentedMy fault, diff was not against the correct branch. Here it is again.
Comment #13
miiimoooPlease port this to D7
Comment #14
podarokbumping version
Comment #15
podarok#12: south_sudan-1271066-12.patch queued for re-testing.
Comment #16
podarokcommited and pushed to both 6.x-3.x and 7.x-3.x dev versions
Thanks!
Comment #17.0
(not verified) CreditAttribution: commentedUpdated issue summary.
Comment #18
miiimoooHas anyone tested this on D7? I looked through the code and I think it requires adding South Sudan to the Drupal core countries list. I could work on a patch I think but wanted to check whether peopel had this working as it is (7.x.-3.1)
Comment #19
miiimoooComment #20
tomogden CreditAttribution: tomogden commentedYes, we performed all due diligence before actually launching with this fix in the U.S. State Department websites, which is why we insisted on it. See https://blogs.state.gov/region/africa . It has proven useful for all our data entry and mapping functions. Below is the stamp from the installed module:
We are running the Countries and Countries Configuration modules as well, which may compensate for what you are seeing. If you can run through a patch to Drupal core, that would be ideal. At the time there just didn't seem much of a change of getting it through.
Comment #21
miiimoooIt doesn't need a patch to Drupal core. This module code does the trick:
Comment #22
jacob.embree CreditAttribution: jacob.embree at St. Louis Integration commentedThe issue here is fixed. Please open a new issue for any discussion about Drupal core or hook_countries_alter.