This issue is part of meta issue #1931088: [META] Fixing tests

I created a patch to add South Sudan, "ss", into the location.inc file. I have attached the patch. It seems to work - South Sudan appears in the country drop down and content can be created with that location and saved with no problems.

I would appreciate it if someone could just check it and let me know if I've missed anything - this is my first patch btw!

Thanks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

esKq’s picture

Subscribe

Sinovchi’s picture

This patch is working for me too. I'm here including location.ss.inc file for South Sudan.

Sinovchi’s picture

FileSize
540 bytes
496 bytes

The attachments: for Sudan and South Sudan

tomogden’s picture

Component: Code » Data update
Status: Active » Reviewed & tested by the community

I have installed this fix in my D7 3.x version, and I believe these files should be committed ASAP on all versions, but for D7 3.x it does not change the country list in Drupal core. You will need something like the Countries module for that.

tomogden’s picture

Category: support » bug

South Sudan is recognized worldwide as a country. This needs to be fixed!

podarok’s picture

Status: Reviewed & tested by the community » Postponed

postponed before tests fix
#1931088: [META] Fixing tests

podarok’s picture

Version: 6.x-3.1 » 6.x-3.x-dev
Status: Postponed » Needs review

tests fixed #1931088: [META] Fixing tests
lets go

Status: Needs review » Needs work

The last submitted patch, southsudan.patch, failed testing.

tomogden’s picture

FileSize
802.65 KB

Here is a patch rolled from the files offered in #3, which should test better than the first exploratory patch. But if not, then we will have a known test result to work with for fixing.

tomogden’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, south_sudan-1271066-9.patch, failed testing.

tomogden’s picture

Status: Needs work » Needs review
FileSize
2.59 KB

My fault, diff was not against the correct branch. Here it is again.

miiimooo’s picture

Please port this to D7

podarok’s picture

Version: 6.x-3.x-dev » 7.x-3.x-dev

bumping version

podarok’s picture

#12: south_sudan-1271066-12.patch queued for re-testing.

podarok’s picture

Status: Needs review » Fixed

commited and pushed to both 6.x-3.x and 7.x-3.x dev versions
Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Updated issue summary.

miiimooo’s picture

Has anyone tested this on D7? I looked through the code and I think it requires adding South Sudan to the Drupal core countries list. I could work on a patch I think but wanted to check whether peopel had this working as it is (7.x.-3.1)

miiimooo’s picture

Issue summary: View changes
Status: Closed (fixed) » Active
tomogden’s picture

Yes, we performed all due diligence before actually launching with this fix in the U.S. State Department websites, which is why we insisted on it. See https://blogs.state.gov/region/africa . It has proven useful for all our data entry and mapping functions. Below is the stamp from the installed module:

; Information added by drupal.org packaging script on 2013-10-30
version = "7.x-3.1"
core = "7.x"
project = "location"
datestamp = "1383154846"

We are running the Countries and Countries Configuration modules as well, which may compensate for what you are seeing. If you can run through a patch to Drupal core, that would be ideal. At the time there just didn't seem much of a change of getting it through.

miiimooo’s picture

It doesn't need a patch to Drupal core. This module code does the trick:

/**
 * Implement hook_countries_alter().
 */

function location_country_feature_countries_alter(&$countries) {
  if (!isset($countries['SS'])) {
    $t = get_t();
    $countries['SS'] = $t('South Sudan');
    asort($countries);
  }
}
jacob.embree’s picture

Status: Active » Fixed

The issue here is fixed. Please open a new issue for any discussion about Drupal core or hook_countries_alter.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.