Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Currently there is some code in drupalorg module to hide the file attachments fieldset on basically everything but issues. That makes sense, because we don't allow images, and that would just encourage people to post them.
However, if we do #528682: Allow inline images to be posted to Drupal.org project pages, docs pages, and comments without any special permissions, this would be no longer necessary. So we could either remove this restriction entirely, or at the very least, remove it for book nodes.
Comment | File | Size | Author |
---|---|---|---|
#1 | drupalorg-show-attachments.patch | 579 bytes | webchick |
Comments
Comment #1
webchickHere's the conservative approach that just does this for documentation.
Comment #2
sunI didn't really study the surrounding code, but based no the visible fragment, the change makes sense and seems to be correct.
Comment #3
webchickdww asked about the origin of this code, and it came from #379072: Attachments are Disabled on Book Pages. The intent was to limit file uploads to only the docs team, since only the docs team has access to the input format to post images. However, now that this restriction has been lifted, it makes sense to lift it for everyone else.
The patch doesn't have enough context to adequately eyeball, so here's the entire relevant chunk of code:
Comment #4
jthorson CreditAttribution: jthorson commentedCouldn't apply the patch on rfay.redesign.devdrupal.org, but that's likely due to it being an old codebase.
Manually made the change, and the file attachment box appeared at /node/add/book, while it wasn't there before the change.
Comment #5
dwwThanks folks. Committed, pushed, and deployed live.