It's my feeling that this module is attempting to do too much.
I'm especially uncomfortable with the addressfield dependency since I'm already using location module, and paypal dependency which is supposed to be totally separate; declaring 2 entity types seems a little extreme, especially considering that the description seems to imply that further extensions are likely.
the most important thing for me is the role subscriptions, which was possible with Ubercart. I feel the module is aiming to be too ambitious, and this is also slowing development.

Comments

rupertj’s picture

rupertj CreditAttribution: rupertj commented

These are what commerce_subscription currently has as dependencies:

dependencies[] = commerce
dependencies[] = commerce_product_reference
dependencies[] = commerce_paypal_wps
dependencies[] = rolereference
dependencies[] = number
dependencies[] = date

You'll notice addressfield isn't in there. I don't know where you got that from. Of those 6 modules, 2 are ones you already have if you have commerce (commerce and commerce_product_reference), one's core (number), one's so common I'll be amazed if you don't have it already (date), which leaves rolereference and commerce_paypal_wps. Both of these are reasonable dependencies for what this modules does.

On the rest, your feedback isn't helpful. I'm open to ideas, but saying "This is wrong" with nothing else helps no one. If you'd like to help improve this module, that's great - how would you do it?

rupertj’s picture

rupertj CreditAttribution: rupertj commented
Status: Active » Closed (won't fix)
andykisaragi’s picture

andykisaragi CreditAttribution: andykisaragi commented

Though it's not listed as a dependency, when enabling the module through drush, I was prompted to download the addressfield module due to commerce_subscription apparently being dependent on it - I suspect that's where matslats got that from.