Invalid argument supplied for foreach() in similarterms_taxonomy_node_get_terms()

I encoutered this bug also.

subscribing

Is this a dup of #1260750: annoying bug The first argument should be an array?
If not please add the full error-message (with line-number etc.)

Warning: Invalid argument supplied for foreach() in similarterms_taxonomy_node_get_terms() (line 517 in sites/all/modules/similarterms/similarterms.module).

no solutios here fix issue

subscribing

Patch fixes this warning and the one in #1260750: annoying bug The first argument should be an array.

AWESOME thanks!

The patch fixes the warning, thanks!

I applied this patch to 7.x-1.x-dev and am still getting the same error. Any thoughts? The module doesn't seem to be functioning as a result.

* Warning: Invalid argument supplied for foreach() in similarterms_taxonomy_node_get_terms_by_vocabulary() (line 536 of similarterms.module).
* Warning: array_keys() expects parameter 1 to be array, null given in similarterms_list() (line 196 of similarterms.module).

with patch getting it when i click on 'Similar entries from the Tags vocabulary.' block configuration
Warning: Invalid argument supplied for foreach() in similarterms_block_configure() (line 112 of /path/sites/all/modules/similarterms/similarterms.module).

I inadvertently contributed to what is probably a duplicate of this issue:#1454412

I submitted a patch there against dev branch.

The code seems to expect $item['taxonomy_term'] to be a fully populated term object of some sort. This doesn't seem to be the case; my debugging only showed $item['tid'].

Here's a fix against dev that resolves my issues. It could probably be more performant by matching the vocabulary machine name provided by $field with the vocabulary identified by $vid (right now it loads taxonomy terms). I'm wondering if I should...

• Load the vocabulary object using taxonomy_vocabulary_load OR
• Load the vocabulary machine name with db_query

Guessing a quick db_query is most performant, but maybe not as kosher, seeing as taxonomy_vocabulary_load() is an interface I can probably count on being around for a while.

I tested this patch against the dev version and seems to work.

I'm slightly confused what the status of this issue is now. Needs review?

Augh. I cannot get these warnings to disappear.

The patch in #7 fails with beta3.

The patch in #14 succeeds with 7.x.-1.x-dev but doesn't resolve the issue.

What am I doing wrong?

Currently using Drupal 7.14 and dev version of Similar By Terms.

The patch above doesn't seem to be adding any checking in the foreach in similarterms_taxonomy_node_get_terms() to see if it is actually an array or not. I didn't look at it in any detail, but would be good to get this resolved.

Last patch didn't solve the problem for me.

Attaching a very simple patch that just adds a couple of "if".

The problem is only showing to me when there are no items to show on a block, so adding an if to only show if the module find terms solves it.

Please test against 7.x-1.x and report back

All patches failed when #19 fixed the issue finally. Thank you!

When applying this against the master branch in the git repo I get:

$ git apply similarterms-1277256-19.patch 
similarterms-1277256-19.patch:20: trailing whitespace.
      } 
error: patch failed: similarterms.module:190
error: similarterms.module: patch does not apply

use patch -p0 (or p1)

It really depends on how the maintainer wants to deal with it. A patch applied with git is often easier to bring in.

This issue should really get brought into the repo and set up for the next release before it's a year old. It's a simple enough check and an annoying enough error.

7.x-1.x is not anymore supported and maintained. Please use 7.x-2.x version for your websites.