Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
[edit] D7 version is now working for link generation (MultiLink Filter)
The MultiLink filter will be done first, then the Redirection module and then (possibly) the Secure Pages support module (if it's needed and practical with the D7 version of secure pages, which I haven't looked at yet.)
Please add your comments and test results here. For non-positive results, please also open an issue in the normal way.
Comments
Comment #1
MyXelf CreditAttribution: MyXelf commentedI was thinking that maybe now could be the moment to split the functionalities of ML into at least one more submodule. My idea would be:
* 1 module to handle the input filter and link generation only
* 1 module to handle all the intelligence behind the link construction
* 1 module to handle the redirection
* 1 module to handle the secure pages (following your stated considerations)
That's it
Anyway, subscribing!
Comment #2
Andy Inman CreditAttribution: Andy Inman commentedYep, totally agree with splitting out the input filter from "core" functionality. In fact I was going to do that before finalising the D6 branch - but I've spent far more time already than I had planned! I am also thinking about adding a "debug" block which shows some information about how ML is deciding which languages and urls to use.
So, D7 is not done completed, but I'll continue working on it next week. I felt it was important to finalise the D6 version first, so that the D7 version can be more or less identical. So, version 2.6 of the D6 branch is out today, and will be the final D6 version (I hope!).
I fixed a few bugs that had never been reported but I found while reviewing the code - #1278958: Cached pages, incorrect links under special circumstances was an important one, though in practice probably didn't affect many people. Also I added redirection for cached pages (anonymous user) to the Redirect module. That took much longer than I had imagined, complex because of the need to use hook_boot and all the problems that involves. But, the result is good I think - the lack of redirection for cached pages meant that on most sites (page caching turned on) the results were inconsistent - you could end up at a different final url depending on whether or not there was a cached version of the page (url) you actually requested. Something like Global Redirect doesn't have this problem as it redirects all users in the same way. ML Redirect needs to take into account their language preference, so maybe allowing Drupal to serve an existing cached page, or maybe redirecting to a different page. So, this is an important enhancement I think, I just hope I can duplicate it in D7!
Not much help to you I know, you just want link generation in D7 :)
Comment #3
MyXelf CreditAttribution: MyXelf commentedNo problem at all! I'm glad you are taking my needs into consideration. But there's also the Drupal community and that's undoubtedly more important.
Thanks a lot
Comment #4
Andy Inman CreditAttribution: Andy Inman commentedThe input filter is now done. The dev release shown on the project page isn't showing the latest yet - it should get updated within 24 hours - in the meantime use git to checkout the project. Instructions at http://drupal.org/project/multilink/git-instructions
Comment #5
MyXelf CreditAttribution: MyXelf commentedI don't know if this will get solved at some point by the contrib-modules-publication-mechanism. But right now there is a mismatch with the packages and the md5 hashes.
ASAP I'll checkout the git repo.
Thanks a lot for your effort, I really appreciate it
Comment #6
MyXelf CreditAttribution: MyXelf commentedAlready reported
#1286526: Unable to modify Text Formats settings after enabling 'MultiLink Filter'
#1286540: MultiLink mispelled accross the module's files
Sorry, but as I can't enable the filter, I can't test any further.
Expecting your answer
MyXelf
Comment #7
Andy Inman CreditAttribution: Andy Inman commentedFixed both of those. Latest version will hopefully be the release version - any further changes will be minor.
Comment #8
Andy Inman CreditAttribution: Andy Inman commentedMajor update to the documentation now at http://drupal.org/node/907514 - the layout is a bit messy (KompoZer editor.)
Comment #9
MyXelf CreditAttribution: MyXelf commentedFixed the layout of the documentation. A little bit better now, I hope.
Comment #10
Andy Inman CreditAttribution: Andy Inman commentedThanks for that - I was finding that editing the documentation page as raw HTML was becoming a pain, so tried a visual editor, but that caused a number of problems. I wish we could have markdown on here - by far my preferred input method. It's available on groups.drupal.org but not here :(
Did you get the D7 MultiLink working now? I am continuing to test and it's working well. There are a few minor changes before release, but it will be on target - tomorrow!
Comment #11
MyXelf CreditAttribution: MyXelf commentedAll you need is VIM :-D But I second you on having Markdown here would be a breeze.
I'm pretty short of time right now. Barely I was able to see all the links correctly generated. Note I'm only using the filter. So far, so good. I'm glad I could be of any help with the docs. If you need anything else, I'll do my best.
Thanks and keep the good work
MyXelf
Comment #12
Andy Inman CreditAttribution: Andy Inman commentedMy tests indicate that all is working well. I have done a few tests with a non-default multilink_language_order setting, and that seems to work well too.
I have just a few changes to upload now (a fix for a very minor security issue.) Then I will create the first "official" D7 release.
Comment #13
Andy Inman CreditAttribution: Andy Inman commentedNow fixed via specific check for running under Drush, new version out shortly.
Comment #14
Andy Inman CreditAttribution: Andy Inman commentedV2.8 now released.
Comment #15
Andy Inman CreditAttribution: Andy Inman commentedComment #15.0
Andy Inman CreditAttribution: Andy Inman commentedupdated status