In companion to: #1277484: --no-core option for archive-dump

When we restore a dump where no core is included the current method, of moving the entire tree in place, fails.

We need some form of copy for this....

I'll work on this in my sandbox: http://drupalcode.org/sandbox/helmo/1277350.git

Comments

helmo’s picture

Status: Active » Needs review

I've pushed code and a test for this.

I've added a property to the MANIFEST.ini file to know if a core was included.
After messing with a boolean, false is not saved to the ini and php also parses it weird, I ended up with 'dump_type' (being platform or site).

Is there a page where the manifest format is described? The most informative I found was http://groups.drupal.org/site-archive-format
As formatversion is currently set to 1.0, this might be something for 1.1?

moshe weitzman’s picture

I don't think we need 1.1 since we can propose that the spec assume dump_type = core. Please propose this new key in that group and we'll see what folks say. adrian had proposed it earlier but we did not act on that at that time.

helmo’s picture

I've opened a new discussion in the site-archive-format group: http://groups.drupal.org/node/176324

Unfortunately there has not been any comment.

moshe weitzman’s picture

Priority: Normal » Major

Would love to get this committed for Aegir.

moshe weitzman’s picture

Status: Needs review » Postponed (maintainer needs more info)
helmo’s picture

Status: Postponed (maintainer needs more info) » Needs review
vinmassaro’s picture

Version: » 8.x-6.x-dev

Would like to get this rolling again since not being able to restore from a --no-core archive dump is a bummer for us. @helmo, would you be willing to re-roll now that --no-core has been committed? Thanks.

helmo’s picture

Assigned: helmo » Unassigned

Most of what I had in mind for this seems to have been included in #1277484: --no-core option for archive-dump.

If your experiencing problems then some debugging might be in order.
What do you have as the value of $ini['Global']['archiveformat'] in your MANIFEST.ini

Otherwise we could call this fixed.

greg.1.anderson’s picture

Status: Needs review » Closed (duplicate)

Marking this as a duplicate of #1277484: --no-core option for archive-dump per #8. Please re-open if there is any more that needs to be done here.