Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
In companion to: #1277484: --no-core option for archive-dump
When we restore a dump where no core is included the current method, of moving the entire tree in place, fails.
We need some form of copy for this....
I'll work on this in my sandbox: http://drupalcode.org/sandbox/helmo/1277350.git
Comments
Comment #1
helmo CreditAttribution: helmo commentedI've pushed code and a test for this.
I've added a property to the MANIFEST.ini file to know if a core was included.
After messing with a boolean, false is not saved to the ini and php also parses it weird, I ended up with 'dump_type' (being platform or site).
Is there a page where the manifest format is described? The most informative I found was http://groups.drupal.org/site-archive-format
As formatversion is currently set to 1.0, this might be something for 1.1?
Comment #2
moshe weitzman CreditAttribution: moshe weitzman commentedI don't think we need 1.1 since we can propose that the spec assume dump_type = core. Please propose this new key in that group and we'll see what folks say. adrian had proposed it earlier but we did not act on that at that time.
Comment #3
helmo CreditAttribution: helmo commentedI've opened a new discussion in the site-archive-format group: http://groups.drupal.org/node/176324
Unfortunately there has not been any comment.
Comment #4
moshe weitzman CreditAttribution: moshe weitzman commentedWould love to get this committed for Aegir.
Comment #5
moshe weitzman CreditAttribution: moshe weitzman commentedComment #6
helmo CreditAttribution: helmo commentedThe main changes for restore are in one commit: http://drupalcode.org/sandbox/helmo/1277350.git/commitdiff/ca8dca0fdbc10...
This link shows all changes in my branch: http://drupalcode.org/sandbox/helmo/1277350.git/commitdiff/master-upstre...
And as plain text: http://drupalcode.org/sandbox/helmo/1277350.git/commitdiff_plain/master-...
I've renamed dump_type to archive_format per the moshe's suggestion in http://groups.drupal.org/node/176324#comment-620564
Comment #7
vinmassaro CreditAttribution: vinmassaro commentedWould like to get this rolling again since not being able to restore from a --no-core archive dump is a bummer for us. @helmo, would you be willing to re-roll now that --no-core has been committed? Thanks.
Comment #8
helmo CreditAttribution: helmo commentedMost of what I had in mind for this seems to have been included in #1277484: --no-core option for archive-dump.
If your experiencing problems then some debugging might be in order.
What do you have as the value of $ini['Global']['archiveformat'] in your MANIFEST.ini
Otherwise we could call this fixed.
Comment #9
greg.1.anderson CreditAttribution: greg.1.anderson commentedMarking this as a duplicate of #1277484: --no-core option for archive-dump per #8. Please re-open if there is any more that needs to be done here.