When implementing a display extender, I get the following PHP strict warning:

Declaration of views_metatags_plugin_display_extender_metatags::option_definition() should be compatible with that of views_object::option_definition()

Sure enough, there is a mismatch.

views_plugin_display:
function option_definition() {

views_plugin_display_extender:
function options_definition(&$options) { }

So either we need to change the base definition of options_definition() or we use a different callback (e.g. options_definition_alter()). This is one of the reasons why I started investigating using drupal_alters() would be easier.

CommentFileSizeAuthor
#11 views-1281698-9.patch1.13 KBtim.plunkett
#8 views-1281698-8.patch977 bytestim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Issue tags: +Metatags

This blocks metatags views integration.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Wouldn't


function options_definition(&$options = array()) { }

work as well?

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

Making a parameter by reference also triggers this warning though.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

What do you think about renaming it to options_definition_alter. /me ducks

Alternative the code which runs the methods could merge together the $options.

Chi’s picture

Chi CreditAttribution: Chi commented
Issue tags: +Code per Views Display

There is relative issue: #1347904: Strict warning: Declaration of cpv_plugin_display_extender_code

beatnbite’s picture

beatnbite CreditAttribution: beatnbite commented

The metatag views integration is an important thing.
Is there any progress on this issue?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

There are several possible ways to do it

a) @ before the function call
b) setting the options in the display plugin object like $object->options and allow to alter it from the display plugin
c) Rename it see #4

In general all seems to be quite hacky.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
FileSize
views-1281698-8.patch977 bytes

Discussed this with dereine in IRC

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Version: 7.x-3.x-dev » 6.x-3.x-dev

Thanks! This would probably require a backport as well

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Patch (to be ported)

Wrong status

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Version: 6.x-3.x-dev » 7.x-3.x-dev
Status: Patch (to be ported) » Needs review
FileSize
views-1281698-9.patch1.13 KB

After further thought, both methods should be available.
The first to define options the plugin is directly responsible, the other to alter existing options.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Version: 7.x-3.x-dev » 6.x-3.x-dev
Status: Needs review » Patch (to be ported)

Setting back after some discussion

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented
Issue summary: View changes
Status: Patch (to be ported) » Closed (outdated)

The Drupal 6 branch is no longer supported, please check with the D6LTS project if you need further support. For more information as to why this issue was closed, please see issue #3030347: Plan to clean process issue queue