In the same vein as #913890: Generate .info file properties in order consistent with core, this bugs me way too much, but I'd like to see it fixed. The docs on writing info files, as well as core .info files themselves, don't use quotes.

CommentFileSizeAuthor
#1 features-1287594-1.patch420 bytestim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Active » Needs review
Issue tags: +Needs backport to D6
FileSize
features-1287594-1.patch420 bytes

See attached.

febbraro’s picture

febbraro CreditAttribution: febbraro commented

Interesting. The packaging script on d.o DO use the double quotes though.

Unstoppable force meets immovable object?

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

I'll patch the packaging script next :) Open source++

Grayside’s picture

Grayside CreditAttribution: Grayside commented

Heh, oddly enough when I saw features do that the bits of C++ in my background grabbed ahold of it and I use the doublequotes universally now.

hefox’s picture

hefox CreditAttribution: hefox commented

Going to be annoying change for updating existing features cause every feature will have changed and need to be feature-updated (the git diff u.u!), but that's not anything unusual. Other than that, looks fine.

Grayside’s picture

Grayside CreditAttribution: Grayside commented

Well, it won't require anything because there is no functional difference in .info parsing. The minor annoyance of the git diff when features are updated, will just have to be choked on.

neochief’s picture

neochief CreditAttribution: neochief commented
Status: Needs review » Reviewed & tested by the community

Looks fine for me either. Those who care and have a lot of features can re-generate them pretty easily with "drush features-update-all", so this shouldn't be a big deal.

mpotter’s picture

mpotter CreditAttribution: mpotter commented
Status: Reviewed & tested by the community » Fixed

Seems good. People are not forced to update their Features because they won't be marked as overridden or anything bad. So this has a low impact and just improves consistency.

Committed to 264a557.

hefox’s picture

hefox CreditAttribution: hefox commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Fixed » Patch (to be ported)

  • mpotter committed 264a557 on 8.x-3.x 
    Issue #1287594 by tim.plunkett: Don't wrap .info file values in double...