I was running into some issues where the bundle property wasn't being set on submissions. Cleaned that up and make sure we test the bundle's type rather than the node's... heck we should probably apply the same test in webform_entity_webform_submission_load().

CommentFileSizeAuthor
webform_entity_loading_wonky.patch4.95 KBdrewish
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drewish’s picture

drewish CreditAttribution: drewish commented
Status: Active » Needs review
drewish’s picture

drewish CreditAttribution: drewish commented
Status: Needs review » Fixed

went ahead and committed that.

tizzo’s picture

tizzo CreditAttribution: tizzo commented

Finally reviewed, nice cleanup and I agree the loss of static caching probably won't make a difference in terms of performance.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.