If it makes sense for comments it likely makes sense for files too.

CommentFileSizeAuthor
#26 file_static_caching_1292374_26.patch4.53 KBBerdir
#23 file_static_caching_1292374_22.patch3.98 KBslashrsm
#20 enable-file-static-caching.patch4.07 KBjbrown
#18 enable-file-static-caching-1292374-17.patch4.06 KBslashrsm
#16 enable-file-static-caching.patch4.43 KBjbrown
#14 enable-file-static-caching.patch4.38 KBjbrown
#10 file-reset-argument.patch1.55 KBjbrown
#7 1292374-file_load_reset_argument-7.patch1.5 KBKevin Morse
#6 1292374-file_load_reset_argument-D7.patch1.48 KBchris.leversuch
#5 1292374-file_load_reset_argument.patch1.5 KBchris.leversuch
#2 file-load-reset.0.patch1.48 KBkarschsp
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Issue tags: +Novice

Tagging as novice. See #1000282: $reset argument missing for comment_load[_multiple]() for how this was applied to comments.

karschsp’s picture

karschsp CreditAttribution: karschsp commented
Assigned: Unassigned » karschsp
Status: Active » Needs review
FileSize
file-load-reset.0.patch1.48 KB

Patch adds $reset parameter to file_load() and file_load_multiple().

marcingy’s picture

marcingy CreditAttribution: marcingy commented

This looks good but needs a reroll after the file move.

marcingy’s picture

marcingy CreditAttribution: marcingy commented
Status: Needs review » Needs work
chris.leversuch’s picture

chris.leversuch CreditAttribution: chris.leversuch commented
Assigned: karschsp » chris.leversuch
Status: Needs work » Needs review
FileSize
1292374-file_load_reset_argument.patch1.5 KB

New patch with core folder

chris.leversuch’s picture

chris.leversuch CreditAttribution: chris.leversuch commented
FileSize
1292374-file_load_reset_argument-D7.patch1.48 KB

D7 version

Kevin Morse’s picture

Kevin Morse CreditAttribution: Kevin Morse commented
FileSize
1292374-file_load_reset_argument-7.patch1.5 KB

This should apply to the latest version of D8

cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
CreditAttribution: cweagans commented
Issue tags: +Needs backport to D7

Updating tags per http://drupal.org/node/1517250

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Issue tags: +sprint, +Media Initiative
jbrown’s picture

jbrown CreditAttribution: jbrown commented
FileSize
file-reset-argument.patch1.55 KB

reroll

Status: Needs review » Needs work
Issue tags: -Novice, -Needs backport to D7, -sprint, -Media Initiative

The last submitted patch, file-reset-argument.patch, failed testing.

jbrown’s picture

jbrown CreditAttribution: jbrown commented
Status: Needs work » Needs review
Issue tags: +Novice, +Needs backport to D7, +sprint, +Media Initiative

#10: file-reset-argument.patch queued for re-testing.

jbrown’s picture

jbrown CreditAttribution: jbrown commented

#1750146: Static caching should not be disabled for file entities is a duplicate

jbrown’s picture

jbrown CreditAttribution: jbrown commented
Title: No $reset argument for file_load()/file_load_multiple() » Enable static caching for File entities
Assigned: chris.leversuch » Unassigned
FileSize
enable-file-static-caching.patch4.38 KB

Status: Needs review » Needs work

The last submitted patch, enable-file-static-caching.patch, failed testing.

jbrown’s picture

jbrown CreditAttribution: jbrown commented
Status: Needs work » Needs review
FileSize
enable-file-static-caching.patch4.43 KB

Status: Needs review » Needs work

The last submitted patch, enable-file-static-caching.patch, failed testing.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented
Status: Needs work » Needs review
FileSize
enable-file-static-caching-1292374-17.patch4.06 KB

This should pass. Hopefully...

jbrown’s picture

jbrown CreditAttribution: jbrown commented

Thanks @slashrsm - this will need to be re-rolled when #1468328: Move file entity info, managed file, and file usage functionality into File module gets in.

jbrown’s picture

jbrown CreditAttribution: jbrown commented
FileSize
enable-file-static-caching.patch4.07 KB
slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented
Issue tags: -Novice, -Needs backport to D7, -sprint, -Media Initiative

#20: enable-file-static-caching.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +Needs backport to D7, +sprint, +Media Initiative

The last submitted patch, enable-file-static-caching.patch, failed testing.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented
Status: Needs work » Needs review
FileSize
file_static_caching_1292374_22.patch3.98 KB

Reroll.

Status: Needs review » Needs work

The last submitted patch, file_static_caching_1292374_22.patch, failed testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

The last patch is missing the part that actually removes the static cache flag from the entity definition (now an annotation)

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs work » Needs review
FileSize
file_static_caching_1292374_26.patch4.53 KB

Re-added that.

jbrown’s picture

jbrown CreditAttribution: jbrown commented
Status: Needs review » Reviewed & tested by the community

Looks good!

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago commented

I agree, patch looks good and makes sense.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented

Agree with @jbrown and @fago.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

Agreed this is ready to fly.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Yep. Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

fortis’s picture

fortis CreditAttribution: fortis as a volunteer and at Redditor commented
Issue summary: View changes

Backport to D7 https://www.drupal.org/node/2678618