Fix Item Select in Views Library

Arthur, I think this is related to some of the javascript work you're doing.

This is a rough patch as a proof of concept. This should replace the current library

I'm not getting a submit button on my views now. :(

Did you clear your views cache?

My views cache is disabled, but I re-reverted the view, cleared cache, and checked again. :/

edited for lack of coffee:

I discovered that the issue is with how the fake submit buttons are created- the JS searches for submits inside the tab HTML to decide if it should append them to the tab or display submit/cancel if they are already present. In the case of the upload tab, the submit/cancel buttons already exist so it does not create them. Likewise, in the case of the view tab since the view has a form (the filters) it will not add the submit.

I think the model of having the JS decide if it should generate the buttons is not a great one- the code assumes somethings about the structure of the submit button which I don't think can be considered consistent. I'm guessing we want to handle this during the plugin declaration and handle it with a theme function if the tab requests the buttons.

Any thoughts on this approach?

For lack of feedback, I went for it. This patch should make views select/cancel work. The upload form also works. For some reason the older library is no longer returning content for me, but I'm pleasantly ignoring it.

Oh, there seems to be a bug if you have a validation error on a file upload and then attempt to browse files from the view tab. The view tab no longer has any files uploaded. I don't think this is a bug specific to this code but figured I'd note it.

After the patch, I get a Submit button on the 'View Library' page, but clicking an image submits the form and closes the window.

Trying to use the "Library" tab throws a pretty nasty error (modals within modals).

And this is what I get when I hit 'Cancel' on the 'Library View'. -- in the modal window

Here's what happens when I hit 'Submit" without selecting anything -- same behavior as 'Cancel'.

Patch applied cleanly and i can confirm the exact same experience as agentrickard with regards to every screenshot he posted.

Note to self: include new files in your diff.

Ok, one more go here. Includes the JS for views.

Now it works ;-).

Brief test in FF 6 (Mac) suggests this is ready for commit, and further improvements can be done after that.

Tested this as well and it worked for me. Committed #12 to Git.
http://drupalcode.org/project/media.git/commit/30fb270

Note that #12 broke the existing non-Views based media library as now it errors out with "Error getting media" now when the tab is selected. Not sure we really care about this through if we're removing it eventually.

http://drupalcode.org/project/media.git/commit/7a2b4e1 was all that was required to fix the JS error. Now both the non-Views and the Views libraries work and select items well. Awesome job arthur!

Crap. I moved that line to make the code more readable. Bad Arthur