Remove Coupons from the checkout

I have created the rule as above but the coupon does not get removed.

I think we need a patch to update module default rule.

I've tried this rule but get the error Fatal error: __clone method called on non-object in /sites/all/modules/commerce/modules/cart/commerce_cart.module on line 736.

The removal of coupons once a user changes the cart would be something really helpful. Ideally we could have a rule's action under Rules Coupon (much like "Create Coupon Line Item" or "Set Coupon Granted Ammount") the would Delete Coupon Line Items from an order.

Here's a first attempt at a patch that provides a 'Remove coupon line item' action. This action will remove all coupons when the event and conditions are met.

Oops, rolled it wrong. Here's an update.

Using only the rules, works, and the coupon is removed from the cart, but there is a error in the page of the site:

Error
The website encountered an unexpected error. Please try again later.
Status message
Coupon removed from order.
Error message
EntityMetadataWrapperException: Unable to get the data property commerce_total as the parent data structure is not set. in EntityStructureWrapper->getPropertyValue() (line 442 of /var/www/sites/dtc/cd-ai.com/subdomains/clientes/html/lusomundo2/profiles/commerce_kickstart/modules/entity/includes/entity.wrapper.inc).

anibal,

I was also encountering this error, but had thought it was unique to my project. Guess not.

What's happening is our 'commerce_coupon_action_remove_coupon_line_item' action is running after the 'Remove product line item' event provided by commerce_cart.module. This event executes commerce_cart_order_product_line_item_delete() which invokes rules_invoke_all('commerce_cart_product_remove', ...) and that calls our action which uses coupon_log_remove() and that runs commerce_line_item_delete(). So I suppose it's a problem of recursion: it's trying to delete a line item that has already been deleted.

The solution was to hack up commerce/modules/cart/commerce_cart.module around line 1154 to load up the cached version of the order before executing commerce_order_save(). Sorry I don't have the exact code at the moment, I'll have to track it down. But it's not very pretty and there should be a better solution. I'll try to post an update soon.

Edit commerce/modules/cart/commerce_cart.module @ line #1153 to look like this:

if (!$skip_save) {
    $orders = commerce_order_load_multiple(array($order->order_id), array(), TRUE);
    $updated_order = reset($orders);

    commerce_order_save($updated_order);
   }

return $updated_order;

Thanks, i'll try it, but i think that the best will be to provide this as a patch so it can be included in the release.

I opened an issue and uploaded the patch: http://drupal.org/node/1408464.

I think the action should look like this?

  $actions['commerce_coupon_action_remove_coupon_line_item'] = array(
    'label' => t('Remove coupon line item'),
    'group' => t('Commerce Coupon'),
    'parameter' => array(
      'commerce_order' => array(
        'type' => 'commerce_order',
        'label' => t('commerce order'),
      ),
      'commerce_line_item' => array(
        'type' => 'commerce_line_item',
        'label' => t('commerce line item'),
      ),
    ),
  );

And i get an undefined function error for coupon_log_remove().

this isn't returning a value either:

$coupon_id = $line_item_wrapper->commerce_coupon_reference->value();

ok fixed it!

and changing status sorry for the spam!

I patched with #14, but it didn't seem to fix the problem for me.

Quick update: After moving to the latest stable Commerce release (7.x-1.2), the patch for Coupon is no longer necessary (see http://drupal.org/node/1408464).

This does not seem to be fixed for me on 7.x-1.2

I have a coupon applied to the cart which I have a real hard time removing. I have cleared my browser history and cookies and if I log in I still have my items in the cart with the applied coupon. Makes it very hard to test rules etc.

Not sure why there isn't a "cancel coupon" button next to each applied coupon?

I agree; a remove coupon option on checkout would be very useful.

darksnow's rule in #1 did it.

We totally need a solution for removing coupons, but we need some work there, I really don't think we should remove stuff from the coupon log but set it to disabled or unactive.

Most of the discussion of this issue has been pushed to the -dev version through #1443570: When removing a coupon from an order, remove it also from log and reset it so we have now an API and rules to remove coupons from the order.

Thanks to everyone participating in this issue!