Attached patch fixes what I am sure are simple typographical errors:

--- a/includes/bootstrap.inc
+++ b/includes/bootstrap.inc
@@ -418,7 +418,7 @@ abstract class DrupalCacheArray implements ArrayAccess {
  * Start the timer with the specified name. If you start and stop the same
  * timer multiple times, the measured intervals will be accumulated.
  *
- * @param name
+ * @param $name
  *   The name of the timer.
  */
function timer_start($name) {
@@ -431,7 +431,7 @@ function timer_start($name) {
/**
  * Read the current timer value without stopping the timer.
  *
- * @param name
+ * @param $name
  *   The name of the timer.
  * @return
  *   The current timer value in ms.
@@ -454,7 +454,7 @@ function timer_read($name) {
/**
  * Stop the timer with the specified name.
  *
- * @param name
+ * @param $name
  *   The name of the timer.
  * @return
  *   A timer array. The array contains the number of times the timer has been
Files: 
CommentFileSizeAuthor
#8 timer_foo-fix_docblock-1295502-8.patch1.03 KBpillarsdotnet
PASSED: [[SimpleTest]]: [MySQL] 33,250 pass(es).
[ View ]
#6 includes--bootstrap_inc-add_missing_dollar_sign.patch960 bytespillarsdotnet
PASSED: [[SimpleTest]]: [MySQL] 33,287 pass(es).
[ View ]
#2 includes--bootstrap_inc-add_missing_dollar_signs-and-blank_lines.patch3.24 KBpillarsdotnet
PASSED: [[SimpleTest]]: [MySQL] 33,137 pass(es).
[ View ]
includes--bootstrap_inc-add_missing_dollar_sign.patch960 bytespillarsdotnet
PASSED: [[SimpleTest]]: [MySQL] 33,140 pass(es).
[ View ]

Comments

While you are in there, could you add a blank line before the @return doc statements? Thanks.

StatusFileSize
new3.24 KB
PASSED: [[SimpleTest]]: [MySQL] 33,137 pass(es).
[ View ]

@Lars Toomre

While you are in there, could you add a blank line before the @return doc statements?

Done, but now it probably won't get reviewed until after November 1st; sigh.

Thank you @pillarsdotnet. As is this looks good to go.

On a side note, do you know if the @param type hinting proposal for docblocks has been approved yet? If so, this patch includes a number of places where that type of docblock change also needs to be implemented.

@Lars Toomre

As is this looks good to go.

Feel free to RTBC; you're obviously qualified and this is a trivial docs-only change.

do you know if the @param type hinting proposal for docblocks has been approved yet?

You can join the discussion at Should all @param data types be documented?
And #1290258: The data type should be explicitly stated for all Drupal core @param and @return documentation.

Status:Needs review» Needs work

PLEASE don't do a whole file at once, just do the functions mentioned in the issue (3 functions, not the whole file!!!!!!!). Then we can actually fix the doc that has problems.

Status:Needs work» Needs review
StatusFileSize
new960 bytes
PASSED: [[SimpleTest]]: [MySQL] 33,287 pass(es).
[ View ]

Whatever. Re-uploading the original patch. Y'all argue amongst yourselves as to which way you want it.

Status:Needs review» Needs work

There's a sweet spot between fixing the blank line problems in the 3 functions named in the issue, and fixing the whole file...

Status:Needs work» Closed (won't fix)
StatusFileSize
new1.03 KB
PASSED: [[SimpleTest]]: [MySQL] 33,250 pass(es).
[ View ]

Fine, but when I submit separate patches for each of the other functions, both you and webchick will complain. She's already complained about the fact that I submitted separate patches for separate files as I found similar problems in each.

I really wish y'all would reach a consensus on these things. And publish it somewhere so I can re-read it when I forget.

Status:Closed (won't fix)» Needs review

Status:Needs review» Reviewed & tested by the community

See http://drupal.org/node/1295500#comment-5068622 regarding the consensus question. I do think that the ideas there represent consensus as in "how things have been going in the last year or two", and sorry they weren't written down somewhere for you.

Anyway, thanks, this patch is good to go for d7/8.

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 8.x and 7.x.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.