Strict warning: Only variables should be passed by reference in ds_views_row_render_taxonomy_term_data() (line 356 of [#1295586]

I was getting a lot errors like:
Strict warning: Only variables should be passed by reference in ds_views_row_render_taxonomy_term_data() (line 356 of /home/johnny/www/rm-drupal/sites/all/modules/drupal.org/ds/views/views_plugin_ds_entity_view.inc).

So I used this simple patch and the errors are away now.

Comment	File	Size	Author
#3	1295586-3-functions_passed_by_ref.patch	3.97 KB	pfrenssen
	ds-ds_views_row_render_taxonomy_term_data-reference-error.patch	650 bytes	Johnny vd Laar

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

swentel CreditAttribution: swentel commented 1 October 2011 at 11:03

Status:

Active

» Fixed

Committed and pushed, thanks!

Comment #2

15 October 2011 at 11:11

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #3

pfrenssen

Sofia

CreditAttribution: pfrenssen commented 4 November 2011 at 13:40

Status:

Closed (fixed)

» Needs review

File	Size
1295586-3-functions_passed_by_ref.patch	3.97 KB

This problem also exists in other parts of Display Suite. I encountered this today when working with users:

Strict warning: Only variables should be passed by reference in ds_views_row_render_users() (line 360 of sites/all/modules/contrib/ds/views/views_plugin_ds_entity_view.inc).

I went through the code and fixed this notice for the entire codebase. I also updated the example in ds.api.php while I was at it.