Inserting a user does not necessarily mean that a $_POST['pass'] exists (Commerce checkout processing for Anonymous users for example). Thus, the following error is thrown:

Notice: Undefined index: pass in aes_user_alter() (line 432 of /public_html/NRDC/GreenGifts/drupal-7.7/sites/all/modules/aes/aes.module).

CommentFileSizeAuthor
#2 1302908-2-check-isset-on-post.patch1.58 KBEvanDonovan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ekristen’s picture

ekristen CreditAttribution: ekristen commented

This function should to check to see if aes passwords is even enabled and if it isn't just return immediately.

This specific error is caused because the function assumes there is always a post which there isn't. If someone calls user_save the hook_user_alter gets called, but no post took place.

EvanDonovan’s picture

EvanDonovan CreditAttribution: EvanDonovan commented
Status: Active » Needs review
FileSize
1302908-2-check-isset-on-post.patch1.58 KB

Here's a patch. Let me know if this solves it.

EvanDonovan’s picture

EvanDonovan CreditAttribution: EvanDonovan commented
Issue tags: +7.x-1.6

Tagging.

ekristen’s picture

ekristen CreditAttribution: ekristen commented
Status: Needs review » Fixed

Good to go.

EvanDonovan’s picture

EvanDonovan CreditAttribution: EvanDonovan commented
Status: Fixed » Reviewed & tested by the community

Should only be marked "fixed" when the patch is committed. I've just been granted maintainership, so will commit soon.

13rac1’s picture

13rac1 CreditAttribution: 13rac1 commented

+1 Works as described. Commit?

jnettik’s picture

jnettik
Primary language English
Location Denver, CO
CreditAttribution: jnettik commented

Tested and works for me as well.

EvanDonovan’s picture

EvanDonovan CreditAttribution: EvanDonovan commented

Committed to -dev: http://drupalcode.org/project/aes.git/commit/32280ea

EvanDonovan’s picture

EvanDonovan CreditAttribution: EvanDonovan commented
Version: 7.x-1.5 » 7.x-1.x-dev
Status: Reviewed & tested by the community » Fixed

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 32280ea on 7.x-1.x, 8.x-2.x by EvanDonovan: 
    Issue #1302908 by EvanDonovan, ekisten, sean_fremouw: Undefined index...