Here is a patch that alters the review pane to show the message with link 'I accept the terms and conditions.' instead of displaying the whole node again.

CommentFileSizeAuthor
#4 make-termsofservice-configurable-1303542-4.patch5.23 KBderjochenmeyer
show-tos-confirmation-status-on-review-pane.patch1.3 KBforward-media
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pcambra’s picture

pcambra
he/him
Primary language Spanish
Location Asturies
CreditAttribution: pcambra commented
Status: Needs review » Postponed (maintainer needs more info)

Hi, not really sure if this is the expected behavior, you can just hide the terms of service pane in the review phase or hide it somehow.

forward-media’s picture

forward-media CreditAttribution: forward-media commented

in germany we have to inform the customer that he checked the checkbox, ... maybe we can configure the module so that the usere can selecte the place the pane should be: in checkout and review or only review or only checkout, ... :) It is a cool and also powerful module, why not more cofigurations :)

pcambra’s picture

pcambra
he/him
Primary language Spanish
Location Asturies
CreditAttribution: pcambra commented

You can move the pane from checkout page to review one.

I suggest you create two nodes, place the terms of service one configured with the mandatory checkbox and uncheck to be placed in review.
Then create a second node with the "you've accepted the tos blablah" and place it in review phase.

derjochenmeyer’s picture

derjochenmeyer CreditAttribution: derjochenmeyer commented
FileSize
make-termsofservice-configurable-1303542-4.patch5.23 KB

Make this configurable.

pcambra’s picture

pcambra
he/him
Primary language Spanish
Location Asturies
CreditAttribution: pcambra commented
Status: Postponed (maintainer needs more info) » Active

Do you find something wrong with the approach proposed in #3?

- Create two ToS nodes, one full, another with the outline for review.
- Configure those nodes to be checkout panes
- Drag the ful ToS node to the checkout form phase, configure it to be required and not to show up in the review phase.
- Drag the outlined ToS node to the review phase

Wondering if I should expose the view mode as an option in the checkout configure pane form.

derjochenmeyer’s picture

derjochenmeyer CreditAttribution: derjochenmeyer commented

There is nothing wrong with that approach. But there is an issue that also the patch does not solve: If the ToS are required the checkout will either fail, or the "you agreed message" will show and will be correct. But if the ToS are not required the "you agreed message" defined in the second node will be wrong.

The approach also does not solve the problem of displaying the full node during the checkout. You can display everything in a collapsed fieldset, but then the checkbox will be collapsed too.

pcambra’s picture

pcambra
he/him
Primary language Spanish
Location Asturies
CreditAttribution: pcambra commented
Status: Active » Needs work

I'd prefer not to store some text variables depending if the user has checked or not the pane, I think your feature request makes a lot of sense, though.

I think that the best solution for this module would be to expose a setting just next to the "display on review" that overrides this one if checked, something like "Display this pane only if terms of service have been checked", this way the requirement would be accomplished and we can rely in having different nodes and not text-based variables, which would be a more generic approach.